classification
Title: Give Cookie.py its own _idmap
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: collinwinter, georg.brandl, splitscreen (3)
Priority: normal Keywords patch

Created on 2006-07-13 15:09 by collinwinter, last changed 2006-08-14 22:01 by georg.brandl.

Files
File name Uploaded Description Edit Remove
give_Cookie_own_idmap.patch collinwinter, 2006-07-13 15:09 Against r50618
Messages (3)
msg50688 - (view) Author: Collin Winter (collinwinter) Date: 2006-07-13 15:09 
Currently, Lib/Cookie.py relies on being able to import
_idmap -- an internal implementation detail -- from
string.py. Given that string.py includes a comment
"Note that Cookie.py bogusly uses _idmap :(", it seems
this might be something worth fixing.

The attached patch resolves this issue by having
Cookie.py generate its own copy of _idmap.
msg50689 - (view) Author: Matt Fleming (splitscreen) Date: 2006-08-03 00:16 
Logged In: YES 
user_id=1126061

For what my opinion's worth, this patch looks fine.
msg50690 - (view) Author: Georg Brandl (georg.brandl) Date: 2006-08-14 22:01 
Logged In: YES 
user_id=849994

Applied as rev. 51290.
History
Date User Action Args
2006-07-13 15:09:48collinwintercreate