Created on 2012-06-28 00:57 by christian.heimes, last changed 2012-08-01 18:03 by haypo.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| urandom_doc.patch | haypo, 2012-08-01 18:03 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg164218 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2012-06-28 00:57 | |
The comment for Python/random.c:_PyOS_URandom() states > Fill buffer with size pseudo-random bytes, not suitable for cryptographic use, from the operating random number generator (RNG). which is not correct as all paths use a RNG that is suitable for most cryptographic purposes except long living private keys for asymmetric encryption. Also the function isn't documented although it's an official API function and plays a vital role on the new hash randomization. |
|||
| msg164222 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2012-06-28 06:27 | |
It's not an official API, as the leading underscore specifies. Changing the comment sounds fine to me. |
|||
| msg167094 - (view) | Author: STINNER Victor (haypo) * |
Date: 2012-08-01 07:24 | |
So can we close this issue, or should we start to document private functions? |
|||
| msg167118 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2012-08-01 12:11 | |
The comment needs to be fixed before the issue is closed. |
|||
| msg167156 - (view) | Author: STINNER Victor (haypo) * |
Date: 2012-08-01 18:03 | |
> The comment needs to be fixed before the issue is closed. Ah yes, here is a patch updating the comment of _PyOS_URandom() and the doc of the os module. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-08-01 18:03:56 | haypo | set | files:
+ urandom_doc.patch keywords: + patch messages: + msg167156 |
| 2012-08-01 12:11:30 | pitrou | set | messages: + msg167118 |
| 2012-08-01 07:24:24 | haypo | set | messages: + msg167094 |
| 2012-06-28 06:27:41 | loewis | set | nosy:
+ loewis messages: + msg164222 |
| 2012-06-28 00:57:03 | christian.heimes | create | |