Created on 2012-06-24 17:32 by georg.brandl, last changed 2012-06-24 21:32 by larry. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| larry.platform.unamedtuple.1.diff | larry, 2012-06-24 21:02 | First patch, no doc changes yet. | review | |
| larry.platform.unamedtuple.2.diff | larry, 2012-06-24 21:17 | Second patch. | review | |
| larry.platform.unamedtuple.3.diff | larry, 2012-06-24 21:27 | patch #3 | review | |
| Messages (6) | |||
|---|---|---|---|
| msg163810 - (view) | Author: Georg Brandl (georg.brandl) *  |
Date: 2012-06-24 17:32 | |
Followup to #15118. See rev 75b818d7c50d -- the patch converted a usage of platform.uname(), which errored out on Mac. Since os.uname() is supposed to be the "low-level" interface, it suggests that platform.uname() should also return an attribute-rich object; in this case probably a namedtuple. |
|||
| msg163860 - (view) | Author: Larry Hastings (larry) * |
Date: 2012-06-24 21:02 | |
Patch isn't ready, no doc changes. But code review can happen. |
|||
| msg163862 - (view) | Author: Larry Hastings (larry) * |
Date: 2012-06-24 21:17 | |
Docs fixed, new unit tests for namedtuple interface added. |
|||
| msg163866 - (view) | Author: Larry Hastings (larry) * |
Date: 2012-06-24 21:27 | |
Third diff, incorporating all of Georg's suggestions. |
|||
| msg163867 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-06-24 21:31 | |
New changeset 344b06318aca by Larry Hastings in branch 'default': Issue #15164: Change return value of platform.uname() from a http://hg.python.org/cpython/rev/344b06318aca |
|||
| msg163868 - (view) | Author: Larry Hastings (larry) * |
Date: 2012-06-24 21:32 | |
Done! And just in time for... something! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-06-24 21:32:25 | larry | set | status: open -> closed type: enhancement messages: + msg163868 resolution: fixed stage: resolved |
| 2012-06-24 21:31:36 | python-dev | set | nosy:
+ python-dev messages: + msg163867 |
| 2012-06-24 21:27:30 | larry | set | files:
+ larry.platform.unamedtuple.3.diff messages: + msg163866 |
| 2012-06-24 21:17:34 | larry | set | files:
+ larry.platform.unamedtuple.2.diff messages: + msg163862 |
| 2012-06-24 21:02:35 | larry | set | files:
+ larry.platform.unamedtuple.1.diff keywords: + patch messages: + msg163860 |
| 2012-06-24 17:32:49 | georg.brandl | create | |