classification
Title: urllib2 redirection fix
Type: Stage:
Components: Library (Lib) Versions: Python 2.4
process
Status: closed Resolution: invalid
Dependencies: Superseder:
Assigned To: Nosy List: batyi, jimjjewett, jjlee, nnorwitz (4)
Priority: normal Keywords: patch

Created on 2006-07-02 06:35 by batyi, last changed 2006-07-11 18:02 by nnorwitz.

Files
File name Uploaded Description Edit Remove
urllib2.patch batyi, 2006-07-02 06:35 urllib2_redirect_with_data.patch
Messages (4)
msg50580 - (view) Author: Petr Gladkikh (batyi) Date: 2006-07-02 06:35 
When redirecting to a new URL, new request is missing
attached data (e.g. when redirecting POST or PUT). Thus
redirected request will be different than original one. 

The patch fixes this problem.


My environment is:
OS: WindowsXP, 
Python version: ActivePython 2.4.2 Build 10
(ActiveState Corp.) based on Python 2.4.2 (#67, Jan 17
2006, 15:36:03) [MSC v.1310 32 bit (Intel)] on win32
msg50581 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-07-03 02:10 
Logged In: YES 
user_id=764593

With a POST (and presumably a PUT), this is required by the 
standard.  I won't argue that it is sensible (why would you 
send the data to someone whose redirects you don't trust), 
but it is the standard.

Making this a settable option would probably be OK, though.

-jJ
msg50582 - (view) Author: John J Lee (jjlee) Date: 2006-07-11 13:37 
Logged In: YES 
user_id=261020

Jim's right that there's no bug here.

Also, it already is optional if you're prepared to subclass
or reimplement HTTPRedirectHandler.  Method redirect_request
is documented and can do whatever you like.

This issue was discussed at length here:

http://python.org/sf/549151

Could somebody close this patch?
msg50583 - (view) Author: Neal Norwitz (nnorwitz) Date: 2006-07-11 18:02 
Logged In: YES 
user_id=33168

Closed as requested.
History
Date User Action Args
2006-07-02 06:35:27batyicreate