classification
Title: 1515163 fix - traceback and str exc
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: anthonybaxter Nosy List: anthonybaxter, georg.brandl, jimjjewett, nobody (4)
Priority: high Keywords: patch

Created on 2006-06-30 21:49 by jimjjewett, last changed 2006-07-24 14:10 by georg.brandl.

Files
File name Uploaded Description Edit Remove
test_traceback.py.diff.txt jimjjewett, 2006-06-30 21:50 extra tests
traceback.py.diff2.txt jimjjewett, 2006-07-01 11:21 better name and retval for helper function
traceback.py.diff3.txt jimjjewett, 2006-07-11 20:24 minimal (but uglier) change
Messages (8)
msg50566 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-06-30 21:49 
1515163 is a regression from 2.4.

It is fairly obscure, as it should only affect 
deprecated string exceptions which also have a value.

raise "string", "string"

On the other hand, I did run into it while trying to 
clean up unittest.  The patch fixes this problem, and 
adds several test cases.

-jJ
msg50567 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-06-30 21:52 
Logged In: YES 
user_id=764593

In order to fix it, I also broke out some repeated code 
into a subfunction, and switched some logic to a more 
modern idiom -- these parts *could* be separated if need 
be, but I won't be able to do it this week.
msg50568 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-06-30 21:53 
Logged In: YES 
user_id=764593

For misc/news, I suggest something like

"Fixed an obscure traceback regression when (deprecated) 
strings are raised."
msg50569 - (view) Author: Nobody/Anonymous (nobody) Date: 2006-07-01 11:19 
Logged In: NO
msg50570 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-07-01 11:21 
Logged In: YES 
user_id=764593
msg50571 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-07-03 02:12 
Logged In: YES 
user_id=764593

I forgot to mention in this tracker that this is a 
regression against 2.4, so it should be fixed even post-
beta, unless we decide to never fix it as part of 
deprecation.
msg50572 - (view) Author: Jim Jewett (jimjjewett) Date: 2006-07-11 20:27 
Logged In: YES 
user_id=764593

traceback.py.diff3.txt is the minimal fix.
traceback.py.diff2.txt is a better fix.

test_traceback.py.diff.txt strengthens the test cases (not 
just this bug; a few others tests as well.)
msg50573 - (view) Author: Georg Brandl (georg.brandl) Date: 2006-07-24 14:10 
Logged In: YES 
user_id=849994

Committed in rev. 50803.
History
Date User Action Args
2006-06-30 21:49:08jimjjewettcreate