classification
Title: curses.resizeterm()
Type: Stage:
Components: None Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: doerwalter, loewis, nnorwitz, scott.dial (4)
Priority: normal Keywords patch

Created on 2006-06-15 12:53 by doerwalter, last changed 2006-06-19 14:54 by scott.dial.

Files
File name Uploaded Description Edit Remove
curses.diff doerwalter, 2006-06-15 12:53
curses2.diff doerwalter, 2006-06-15 13:06
Messages (11)
msg50464 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-15 12:53 
This patch add curses.resizeterm()
msg50465 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-15 13:06 
Logged In: YES 
user_id=89016

This second version adds a wrapper for resize_term() too.
msg50466 - (view) Author: Martin v. Löwis (loewis) Date: 2006-06-16 05:11 
Logged In: YES 
user_id=21627

AFAICT, Solaris curses does not have resize_term, so you
need to add a configure test for it.
msg50467 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-16 07:48 
Logged In: YES 
user_id=89016

Isn't it sufficient that the code is in the #ifdef
STRICT_SYSV_CURSES block?
msg50468 - (view) Author: Scott Dial (scott.dial) Date: 2006-06-17 07:00 
Logged In: YES 
user_id=383208

I have taken the liberty (and my inability to sleep) to
update this patch in accordance with the recommendation of a
configure check. This version also includes is_term_resized
which goes along with the resize[_]term functions.

http://scottdial.com/python-dev/curses-resizeterm.diff

* It is worthy of note that my version of autoconf seemed to
want to quote some things that the trunk version didn't so
it perhaps you'd like to run "autoconf" to be safe.
msg50469 - (view) Author: Neal Norwitz (nnorwitz) Date: 2006-06-18 18:21 
Logged In: YES 
user_id=33168

I'm ok with the idea of this patch for 2.5 if you can get in
before the freeze.  If you do check in, be sure to watch the
buildbots.  But I have some specific comments/concerns below.

A couple of notes about Scott's patch.  I would prefer the
macro name to be HAVE_CURSES_RESIZETERM.  I don't understand
why there are 2 variants with and without the _.  I see
there are 2 different curses APIs.  Does the single HAVE_
cover the cases of having is_term_resized, resize_term, and
resizeterm?  It seems like it might be better to have 2 or 3
configure checks.
msg50470 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-18 22:08 
Logged In: YES 
user_id=89016

The man page states: "Most of the work is done by the inner
function resize_term.  The outer function resizeterm adds
bookkeeping for the SIGWINCH handler." All three functions
are closely related and are documented on the same man page,
so we should be safe with one check. I'll change the macro
name and check in the patch tomorrow morning.
msg50471 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-19 08:08 
Logged In: YES 
user_id=89016

Checked in a version that does three separate configure
checks as r47022. I'll close the patch, once all buildbot
have survived the checkin.
msg50472 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-19 10:15 
Logged In: YES 
user_id=89016

Looks good, closing the patch. Thanks to Scoll for the patch!
msg50473 - (view) Author: Walter Dörwald (doerwalter) Date: 2006-06-19 10:44 
Logged In: YES 
user_id=89016

Oops, sorry I meant Scott! ;)
msg50474 - (view) Author: Scott Dial (scott.dial) Date: 2006-06-19 14:54 
Logged In: YES 
user_id=383208

Haha, nice typo. No problem. Glad to help and hope to
continue to do so in the future.

For what it's worth, I couldn't find a platform that one of
the functions but not the others (though, in fact, I could
only find a Solaris box which had none). But obviously
checking each of them would be wise.
History
Date User Action Args
2006-06-15 12:53:20doerwaltercreate