classification
Title: Conditional compilation of zlib.(de)compressobj.copy
Type: Stage:
Components: Extension Modules Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: nnorwitz Nosy List: catlee, nnorwitz (2)
Priority: high Keywords patch

Created on 2006-06-08 17:22 by catlee, last changed 2006-06-12 03:36 by nnorwitz.

Files
File name Uploaded Description Edit Remove
zlib-conditional.patch catlee, 2006-06-08 17:22 Patch against r46756 to add copy methods to (de)compression objects only if the zlib library supports it
Messages (3)
msg50443 - (view) Author: Chris AtLee (catlee) Date: 2006-06-08 17:22 
First pass at a patch to only compile the new copy()
methods for (de)compression objects in zlib if the zlib
library supports them.

I ran autoheader to pick up the AC_DEFINE from
configure.in, and it looks like it changed
pyconfig.h.in quite a bit.  Probably the only part that
needs to stay in is the #undef ZLIB_HAS_COPY part.

If inflateCopy() is not found in the zlib library, then
the copy() methods are not compiled.

Lib/test_zlib.py has been updated to only test these
methods if they exist.
msg50444 - (view) Author: Neal Norwitz (nnorwitz) Date: 2006-06-12 03:34 
Logged In: YES 
user_id=33168

Thanks!  I changed ZLIB_HAS_COPY to HAVE_ZLIB_COPY to be
more consistent with the rest of pyconfig.h.in.

Committed revision 46886.
msg50445 - (view) Author: Neal Norwitz (nnorwitz) Date: 2006-06-12 03:36 
Logged In: YES 
user_id=33168

Thanks!  I changed ZLIB_HAS_COPY to HAVE_ZLIB_COPY to be
more consistent with the rest of pyconfig.h.in.

Committed revision 46886.
History
Date User Action Args
2006-06-08 17:22:06catleecreate