classification
Title: email package does not register defect when blank line between header and body is missing
Type: enhancement Stage: resolved
Components: email Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: r.david.murray Nosy List: barry, python-dev, r.david.murray
Priority: normal Keywords: patch

Created on 2012-05-27 15:25 by r.david.murray, last changed 2012-05-28 00:59 by r.david.murray. This issue is now closed.

Files
File name Uploaded Description Edit
bodyseparator.patch r.david.murray, 2012-05-27 15:25 review
Messages (2)
msg161708 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2012-05-27 15:25
The error recovery heuristic the parser uses is that if it sees a line with no leading whitespace and no ':' in it, it assumes that the blank line between the headers and the body was missing.  It does not, however, register defect for this case.

Attached is a patch.  It introduces a new Defect and deprecates an old one that could never have been issued, so I'm not going to back port it.  (Especially seeing as no one has ever complained about it...I found the bug through code inspection.)
msg161744 - (view) Author: Roundup Robot (python-dev) Date: 2012-05-28 00:45
New changeset 0869f5f47608 by R David Murray in branch 'default':
#14925: email now registers a defect for missing header/body separator.
http://hg.python.org/cpython/rev/0869f5f47608
History
Date User Action Args
2012-05-28 00:59:16r.david.murraysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2012-05-28 00:45:17python-devsetnosy: + python-dev
messages: + msg161744
2012-05-27 15:25:29r.david.murraycreate