When I run "make tests" I get (amongst others) the following test failure:

======================================================================
FAIL: test_noargs (test.test_tools.ReindentTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ronald/Projects/python/rw/default/Lib/test/test_tools.py", line 30, in test_noargs
    assert_python_ok(self.script)
  File "/Users/ronald/Projects/python/rw/default/Lib/test/script_helper.py", line 53, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/Users/ronald/Projects/python/rw/default/Lib/test/script_helper.py", line 45, in _assert_python
    "stderr follows:\n%s" % (rc, err.decode('ascii', 'ignore')))
AssertionError: Process return code is 2, stderr follows:
/Users/ronald/Projects/python/rw/default/build/python.exe: can't open file '/Users/ronald/Projects/python/rw/default/build/Tools/scripts/reindent.py': [Errno 2] No such file or directory


This is because the script is actually "/Users/ronald/Projects/python/rw/default/Tools/scripts/reindent.py".

The attached patch fixes the issue.

(assigned to eric because he introduced these tests, unless there are objections I'll commit during the weekend)

Thanks for catching this.  The definition of projectbase and srcdir is not clear to me, I always have to use trial and error to find the right one in my tests.  The patch must be applied to all three branches; let me know if I should do it.

another one is in Lib/packaging/tests/support.py - should be from same commit

Looks like this issue was addressed with 6d0c54b99ca9 (2.7), 5493299df0a0 (3.2) and c23b442b5d5e (default).  Close?

No - it is broken.

Test_tools passes for me with the tip of the default branch and BUILDDIR!=SRCDIR.

I'm currently running a 2.7 test run, but AFAIK this issue is fixed.

2.7 works as well. 

Roumen: what doesn't work and how can we reproduce that?

I've closed the issue because I can no longer reproduce the issue, the changesets mentioned by Ned have fixed the problem.