classification
Title: patch to make msvccompiler.py work with vs 2005(MSVC8)
Type: compile error Stage:
Components: Installation Versions: Python 3.0, Python 2.6
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, loewis, weck
Priority: normal Keywords: patch

Created on 2007-11-15 14:21 by weck, last changed 2007-11-15 18:25 by loewis. This issue is now closed.

Files
File name Uploaded Description Edit
msvccompiler.py.diff weck, 2007-11-15 14:21
Messages (3)
msg57530 - (view) Author: zouguangxian (weck) Date: 2007-11-15 14:21
It seems that the directory information of MSVC8 *just* can be got from 
environment variable instead of registry. 

This patch make me compile pywin32 with MSVC8(VS 2005).
msg57536 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-11-15 16:10
I've checked your patch. It's not enough to move to VS 2005 as the
default compiler. People expect python setup.py to work w/o opening a VS
2005 Command Prompt.
msg57542 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2007-11-15 18:25
tiran is correct. distutils should work without having to invoke a VS
build environment. Relying on that environment would have worked way
back to VC6 and earlier, but it would reduce the ease of use of distutils.

Rejecting the patch.
History
Date User Action Args
2007-11-15 18:25:25loewissetstatus: open -> closed
resolution: rejected
messages: + msg57542
nosy: + loewis
2007-11-15 16:10:14christian.heimessetnosy: + christian.heimes
messages: + msg57536
2007-11-15 15:59:19christian.heimessetkeywords: + patch
components: + Installation
versions: + Python 2.6, Python 3.0, - Python 2.5
2007-11-15 14:21:35weckcreate