classification
Title: test_smtplib.py lacks "import errno"
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.3
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: giampaolo.rodola, pino, python-dev, r.david.murray, rosslagerwall
Priority: normal Keywords: easy

Created on 2012-03-29 14:47 by pino, last changed 2012-03-29 18:24 by r.david.murray. This issue is now closed.

Messages (5)
msg157052 - (view) Author: Pino Toscano (pino) Date: 2012-03-29 14:47
In Lib/test/test_smtplib.py, there's a try ... except which checks the errno of the IOError exception; though, the errno module is not imported, eventually causing
| NameError: global name 'errno' is not defined
in such case.
msg157062 - (view) Author: Roundup Robot (python-dev) Date: 2012-03-29 16:13
New changeset 9c2b710da3c7 by Ross Lagerwall in branch 'default':
Issue #14442: Add missing errno import in test_smtplib.
http://hg.python.org/cpython/rev/9c2b710da3c7
msg157064 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2012-03-29 16:34
Thanks Ross.  I don't think this is worth a news item, even though the bug was shipped in an alpha.  If someone disagrees please add one.
msg157077 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2012-03-29 18:21
> Thanks Ross.  I don't think this is worth a news item, even though the
> bug was shipped in an alpha.  If someone disagrees please add one.

I did add it to the [Tests] section in 9c2b710da3c7. Hardly worth it, but ...
msg157078 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2012-03-29 18:24
Ah, woops, I *thought* I'd looked at the diff, but obviously I didn't.  Sigh.
History
Date User Action Args
2012-03-29 18:24:55r.david.murraysetmessages: + msg157078
2012-03-29 18:21:50rosslagerwallsetnosy: + rosslagerwall
messages: + msg157077
2012-03-29 16:34:40r.david.murraysetstatus: open -> closed
type: behavior
messages: + msg157064

stage: needs patch -> resolved
2012-03-29 16:13:03python-devsetnosy: + python-dev
messages: + msg157062
2012-03-29 16:12:54pitrousetkeywords: + easy
nosy: + giampaolo.rodola, r.david.murray

stage: needs patch
2012-03-29 14:47:30pinocreate