➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012-03-17 15:08 by eli.bendersky, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue14349.1.patch | eli.bendersky, 2012-03-23 12:14 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg156161 - (view) | Author: Eli Bendersky (eli.bendersky) *  |
Date: 2012-03-17 15:08 | |
The documentation of the MAKE_FUNCTION opcode in 'dis' says: "Pushes a new function object on the stack. TOS is the code associated with the function. " Which doesn't appear to be true. In Python/ceval.c: [...] TARGET_WITH_IMPL(MAKE_CLOSURE, _make_function) TARGET(MAKE_FUNCTION) _make_function: { int posdefaults = oparg & 0xff; int kwdefaults = (oparg>>8) & 0xff; int num_annotations = (oparg >> 16) & 0x7fff; w = POP(); /* qualname */ v = POP(); /* code object */ x = PyFunction_NewWithQualName(v, f->f_globals, w); [...] |
|||
| msg156649 - (view) | Author: Eli Bendersky (eli.bendersky) * |
Date: 2012-03-23 12:14 | |
Patch attached. |
|||
| msg156692 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2012-03-24 12:18 | |
Looks good to me. |
|||
| msg156707 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2012-03-24 16:53 | |
New changeset 242d3f8e8c50 by Eli Bendersky in branch 'default': Issue #14349: Fix the doc of the MAKE_FUNCTION opcode in Doc/library/dis.rst to http://hg.python.org/cpython/rev/242d3f8e8c50 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:28 | admin | set | github: 58557 |
| 2012-03-24 16:54:09 | eli.bendersky | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2012-03-24 16:53:23 | python-dev | set | nosy:
+ python-dev messages: + msg156707 |
| 2012-03-24 12:18:30 | georg.brandl | set | nosy:
+ georg.brandl messages: + msg156692 |
| 2012-03-23 12:14:50 | eli.bendersky | set | files:
+ issue14349.1.patch keywords: + patch messages: + msg156649 stage: needs patch -> patch review |
| 2012-03-17 15:59:37 | georg.brandl | set | assignee: docs@python -> pitrou nosy: + pitrou |
| 2012-03-17 15:08:05 | eli.bendersky | create | |