This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Mercurial version information not appearing in Windows builds
Type: behavior Stage: resolved
Components: Build, Windows Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brian.curtin, loewis, python-dev, vinay.sajip
Priority: normal Keywords: needs review

Created on 2012-02-22 23:37 by vinay.sajip, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
build-info.diff vinay.sajip, 2012-02-22 23:37 Changes to make_buildinfo.c to include Mercurial revision information review
Messages (5)
msg154014 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-02-22 23:37
Currently, the Mercurial revision information is not appearing in Windows builds - they always appear to be "default". This appears to be because the relevant information is not passed to getbuildinfo.c.

The attached patch rectifies this, making the assumption that "hg" will always be accessible on the path. The basic method is to call "hg id -bit" and then pass the branch, tag and revision information when compiling getbuildinfo.c.

If "hg" is not in the path, no Mercurial information is added (i.e. the current behaviour).
msg154016 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-02-22 23:43
Added Brian to nosy, as he said on IRC that he would look into my query about this.
msg159943 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-05-04 16:48
I'd like to commit this soon. Any chance of a review? It's a very small patch, so it shouldn't need much time.
msg159945 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2012-05-04 16:55
Please go ahead and apply it.
msg159967 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-05-04 19:52
New changeset 4459d82ff127 by Vinay Sajip in branch 'default':
Closes #14093: Added Mercurial version information to Windows builds.
http://hg.python.org/cpython/rev/4459d82ff127
History
Date User Action Args
2022-04-11 14:57:27adminsetgithub: 58301
2012-05-04 19:52:06python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg159967

resolution: fixed
stage: patch review -> resolved
2012-05-04 16:55:13loewissetmessages: + msg159945
2012-05-04 16:48:10vinay.sajipsetkeywords: + needs review, - patch

messages: + msg159943
2012-02-22 23:43:10vinay.sajipsetnosy: + brian.curtin
messages: + msg154016
2012-02-22 23:37:06vinay.sajipcreate