This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_importlib failure on Mac OS X
Type: behavior Stage: resolved
Components: Library (Lib), macOS Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, ned.deily, pitrou, python-dev, ronaldoussoren, vinay.sajip
Priority: normal Keywords: patch

Created on 2012-02-20 11:06 by vinay.sajip, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
impcasing.patch pitrou, 2012-02-20 20:44 review
Messages (10)
msg153776 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2012-02-20 11:06
======================================================================
FAIL: test_insensitive (importlib.test.source.test_case_sensitivity.CaseSensitivityTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/importlib/test/source/test_case_sensitivity.py", line 56, in test_insensitive
    self.assertIn(self.name, sensitive.get_filename(self.name))
AssertionError: 'MoDuLe' not found in '/var/folders/ZN/ZNY48Gb3FyW7he0qBsYJME+++TI/-Tmp-/tmpx6934s/sensitive/module.py'

Failure occurs when tested using a framework build (make frameworkinstall) on Mac OS X 10.5.8 (Leopard).
msg153777 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-02-20 12:20
Also fails on 10.7 standard unix (non-framework) build on case-insensitive HFS+ fils system.
msg153789 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2012-02-20 18:28
Antoine, do you think this may have been triggered by your latest patch?
msg153791 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-02-20 18:30
> Antoine, do you think this may have been triggered by your latest patch?

I don't know, perhaps Vinay can bisect to find the offending commit?
(I don't have a Mac)
msg153792 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2012-02-20 18:31
I have a Mac, but I'm heading out the door; I will see if I can diagnose it and fix it tonight or tomorrow (unless someone beats me to it).
msg153800 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-02-20 20:20
The first bad revision is:
changeset:   75048:bbaab666e6c7
parent:      75045:5b4b70bd2b6f
user:        Antoine Pitrou <solipsis@pitrou.net>
date:        Mon Feb 20 01:48:16 2012 +0100
summary:     Issue #14043: Speed up importlib's _FileFinder by at least 8x, and add a new importlib.invalidate_caches() function.
msg153803 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-02-20 20:44
Can you please try this patch?
msg153804 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-02-20 20:55
With impcasing.patch applied, test_importlib passes on OS X (10.7 with case-insensitive fs).
msg153805 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-02-20 21:10
New changeset 3297dcdad196 by Antoine Pitrou in branch 'default':
Issue #14063: fix test_importlib failure under OS X case-insensitive filesystems
http://hg.python.org/cpython/rev/3297dcdad196
msg153807 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-02-20 21:11
Ok, thanks for testing!
History
Date User Action Args
2022-04-11 14:57:26adminsetgithub: 58271
2012-02-20 21:11:55pitrousetstatus: open -> closed
resolution: fixed
messages: + msg153807

stage: resolved
2012-02-20 21:10:28python-devsetnosy: + python-dev
messages: + msg153805
2012-02-20 20:55:57ned.deilysetmessages: + msg153804
2012-02-20 20:44:52pitrousetfiles: + impcasing.patch
assignee: brett.cannon ->
messages: + msg153803

keywords: + patch
2012-02-20 20:20:45ned.deilysetmessages: + msg153800
2012-02-20 18:31:38brett.cannonsetmessages: + msg153792
2012-02-20 18:30:30pitrousetmessages: + msg153791
2012-02-20 18:28:22brett.cannonsetnosy: + pitrou
messages: + msg153789
2012-02-20 12:20:49ned.deilysetassignee: ronaldoussoren -> brett.cannon

messages: + msg153777
nosy: + ned.deily
2012-02-20 11:06:05vinay.sajipcreate