Created on 2012-01-28 11:12 by gruszczy, last changed 2012-02-04 09:51 by terry.reedy.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 13896.patch | gruszczy, 2012-01-28 11:12 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg152159 - (view) | Author: Filip Gruszczyński (gruszczy) | Date: 2012-01-28 11:12 | |
It would be cool if use could use with to manage shelf object and forget about close. |
|||
| msg152185 - (view) | Author: Zachary Richey (zachary r.) | Date: 2012-01-28 20:03 | |
The docs for shelve(see: http://docs.python.org/dev/library/shelve.html#shelve.open) recommend using contextlib.closing for this purpose. |
|||
| msg152236 - (view) | Author: Filip Gruszczyński (gruszczy) | Date: 2012-01-29 15:29 | |
Oh, I haven't noticed that. Using contextlib.closing solves my problem. Thanks. |
|||
| msg152575 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2012-02-04 01:40 | |
contextlib.closing is an adapter for using objects that have a close method but have not be modernized to be context managers by having _enter__ and __exit__ methods added. Its doc gives the example
with closing(urlopen('http://www.python.org')) as page:
This is now obsolete as the object returned is now a context manager.
A shelf instance would make a better example now, but...
I think it reasonable to update shelve.Shelf also. I believe
def __enter__(self): return self
def __exit__(self, e_typ, e_val, tb): self.close()
are all that are needed. (Nick, true?)
|
|||
| msg152604 - (view) | Author: Filip Gruszczyński (gruszczy) | Date: 2012-02-04 08:55 | |
closing was solving my problem, but I'll be happy on working on this patch, if you think it's useful after all. I don't think the stage should be test needed, since the patch has tests (I know the drill here ;-)). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-02-04 09:51:16 | terry.reedy | set | stage: test needed -> patch review |
| 2012-02-04 08:55:03 | gruszczy | set | messages: + msg152604 |
| 2012-02-04 01:41:00 | terry.reedy | set | versions:
+ Python 3.3 nosy: + terry.reedy, ncoghlan title: shelf doesn't work with 'with' -> Make shelf instances work with 'with' as context managers messages: + msg152575 type: enhancement stage: test needed |
| 2012-01-29 15:29:01 | gruszczy | set | messages: + msg152236 |
| 2012-01-28 20:03:26 | zachary r. | set | nosy:
+ zachary r. messages: + msg152185 |
| 2012-01-28 11:12:56 | gruszczy | set | files:
+ 13896.patch keywords: + patch |
| 2012-01-28 11:12:29 | gruszczy | create | |