Created on 2011-11-05 21:30 by amaury.forgeotdarc, last changed 2011-11-06 14:18 by amaury.forgeotdarc. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| FromFormat.diff | amaury.forgeotdarc, 2011-11-05 21:30 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg147112 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) *  |
Date: 2011-11-05 21:30 | |
A code simplification suggested by a comment in issue13349: Replace most usages of PyUnicode_Format (a.k.a. str.__mod__) by PyUnicode_FromFormat, which is easier to use from C: no need to build a tuple, and the format accept both C strings (%s) and Python strings (%S or %R) |
|||
| msg147144 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2011-11-06 07:13 | |
+1 |
|||
| msg147154 - (view) | Author: Petri Lehtinen (petri.lehtinen) * |
Date: 2011-11-06 11:52 | |
This would chop unnecessary lines of code very nicely. +1 |
|||
| msg147159 - (view) | Author: Roundup Robot (python-dev) | Date: 2011-11-06 14:15 | |
New changeset 386a319b1825 by Amaury Forgeot d'Arc in branch 'default': Issue #13350: Replace most usages of PyUnicode_Format by PyUnicode_FromFormat. http://hg.python.org/cpython/rev/386a319b1825 |
|||
| msg147160 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * |
Date: 2011-11-06 14:18 | |
Now PyUnicode_Format is only called by unicode_mod... |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-11-06 14:18:09 | amaury.forgeotdarc | set | status: open -> closed resolution: fixed messages: + msg147160 |
| 2011-11-06 14:15:34 | python-dev | set | nosy:
+ python-dev messages: + msg147159 |
| 2011-11-06 11:52:59 | petri.lehtinen | set | messages: + msg147154 |
| 2011-11-06 07:13:29 | loewis | set | nosy:
+ loewis messages: + msg147144 |
| 2011-11-05 21:30:34 | amaury.forgeotdarc | create | |