classification
Title: Missing semicolon at Modules/posixsubprocess.c:4511
Type: compile error Stage: resolved
Components: Extension Modules Versions: Python 3.4, Python 3.1, Python 3.2, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: rosslagerwall Nosy List: nneonneo, python-dev, rosslagerwall
Priority: normal Keywords:

Created on 2011-11-04 04:34 by nneonneo, last changed 2012-05-16 05:07 by python-dev. This issue is now closed.

Messages (4)
msg146995 - (view) Author: Robert Xiao (nneonneo) * Date: 2011-11-04 04:34
Line 4511 of Modules/posixsubprocess.c is missing a semicolon, so it would not compile successfully if the relevant build flags were enabled (PYOS_OS2).

Trivial patch:
@@ -4508,7 +4508,7 @@
 static PyObject *
 posix_spawnvpe(PyObject *self, PyObject *args)
 {
-    PyObject *opath
+    PyObject *opath;
     char *path;
     PyObject *argv, *env;
     char **argvlist;

No tests needed since it's a compile error.
msg146996 - (view) Author: Roundup Robot (python-dev) Date: 2011-11-04 05:15
New changeset fa9c69dcf31b by Ross Lagerwall in branch '3.2':
Issue #13339: Fix compile error in posixmodule.c due to missing semicolon.
http://hg.python.org/cpython/rev/fa9c69dcf31b

New changeset 9e5d14aadca4 by Ross Lagerwall in branch 'default':
(Merge 3.2) Issue #13339.
http://hg.python.org/cpython/rev/9e5d14aadca4
msg146997 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2011-11-04 06:41
Thanks!
msg160803 - (view) Author: Roundup Robot (python-dev) Date: 2012-05-16 05:07
New changeset 91ac9c36f09e by √Čric Araujo in branch 'default':
Harmonize error messages and add one missing test for #13339
http://hg.python.org/distutils2/rev/91ac9c36f09e
History
Date User Action Args
2012-05-16 05:07:32python-devsetmessages: + msg160803
2011-11-04 06:41:20rosslagerwallsetstatus: open -> closed

assignee: rosslagerwall

nosy: + rosslagerwall
messages: + msg146997
resolution: fixed
stage: resolved
2011-11-04 05:15:39python-devsetnosy: + python-dev
messages: + msg146996
2011-11-04 04:34:23nneonneocreate