This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Missing call to quote_plus() in test_urllib.test_default_quoting()
Type: behavior Stage: resolved
Components: Tests Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: orsenthil Nosy List: jon, orsenthil, python-dev
Priority: normal Keywords: patch

Created on 2011-09-07 05:58 by jon, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_urllib.default_quoting.patch jon, 2011-09-07 05:58 Add a missing quote_plus() call to test_urllib.test_default_quoting() review
Messages (3)
msg143663 - (view) Author: Jon Parise (jon) Date: 2011-09-07 05:58
test_default_quoting() runs a number of identical tests on both quote() and quote_plus() (which is most cases have equivalent behavior).  However, at the end of the method, there appears to be a missing complementary call to quote_plus() despite there being an assertion call for the quote_plus() case.
msg143941 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-09-12 22:42
New changeset e25526865339 by Senthil Kumaran in branch 'default':
merge from 3.2 - Add the missing quote_plus call. Fix closes Issue12924
http://hg.python.org/cpython/rev/e25526865339

New changeset e8d8eb9e05fd by Senthil Kumaran in branch '2.7':
Port the fix for Issue12924 (missing quote_plus) to 2.7 branch.
http://hg.python.org/cpython/rev/e8d8eb9e05fd
msg143942 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2011-09-12 22:43
jon, thanks for the bug report. Fixed and closed in all the branches.
History
Date User Action Args
2022-04-11 14:57:21adminsetgithub: 57133
2011-09-12 22:43:23orsenthilsetmessages: + msg143942
2011-09-12 22:42:44python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg143941

resolution: fixed
stage: resolved
2011-09-07 06:13:38orsenthilsetassignee: orsenthil

nosy: + orsenthil
2011-09-07 05:58:32joncreate