If cgitb.enable is ran with a logdir set and a format='text' argument, then a trailing message is printed that includes <p> tags.  This should only happen if the format requested is HTML.

The following tiny script shows the problem:

import cgitb
cgitb.enable(format='text', logdir='/tmp')
1/0

Attaching a small patch which addresses. This is against tip on the default branch.

mcjeff@macbook:~/cpython$ ./python.exe --version
Python 3.3.0a0

Is there anything else needed here?

A test?

I didn't add one initially as I was just changing output format and not actual behavior.  I guess I could add something to ensure it doesn't regress? I'll make sure there's coverage to begin with.

Test to ensure html isn't included when the formatting is text.  I don't seem to be able to update the stage.

Thanks for the updated patch.  I made a review, you should have received an email.  When you make a new patch, it would be most helpful if you could make one patch with code and tests changes, and then we’ll remove the old versions.

Added everything to one file. Updated tests to also include a logdir argument as that is required to trigger the original bug.  Weeded out a spurious write that occurred when format was set to text.

Latest patch is good to go.

Did this ever get committed? Is there anything left for me to do here?

I’ll apply it shortly.