This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Coverage of smtpd.py
Type: Stage: resolved
Components: Library (Lib), Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: barry, berker.peksag, giampaolo.rodola, ncoghlan, r.david.murray, tleeuwenburg
Priority: normal Keywords: patch

Created on 2011-08-22 08:25 by tleeuwenburg, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
PureProxy.diff tleeuwenburg, 2011-08-22 08:25 review
Messages (3)
msg142696 - (view) Author: Tennessee Leeuwenburg (tleeuwenburg) Date: 2011-08-22 08:25
Okay, I really don't know if I'm doing the right things to test meaningfully here. However, 100% coverage of the PureProxy class has been achieved.

I also slightly changed smtpd.py in a way that I'm not confident is what people would want. I pushed one print statement into the debug stream, and raised an exception in a place where it looked like the expected behaviour wasn't properly defined, but it's probably not a good place to fail if you're using the code.

I'm also not an SMTP expert... yes there's an RFC but I was going for coverage with "just enough" correctness.

I'm more than happy to revisit this work if anyone has any comments or issues, so just let me know.
msg221630 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-06-26 18:59
There are comments on rietvield but I'm not sure whether or not they've been picked up.  In any case can somebody set the appropriate fields and give us a commit review please.
msg309743 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-01-10 00:45
smtpd.py is deprecated so there's really almost zero chance we'll be doing any development on it.  Please check out 

http://aiosmtpd.readthedocs.io/en/latest/

for a third party replacement (maybe pulled into the stdlib for 3.8?)
History
Date User Action Args
2022-04-11 14:57:20adminsetgithub: 57024
2018-01-10 00:45:00barrysetstatus: open -> closed
resolution: wont fix
messages: + msg309743

stage: resolved
2017-06-07 14:08:30BreamoreBoysetnosy: - BreamoreBoy
2017-06-07 11:16:47zvynsetnosy: - zvyn
2014-07-08 23:45:55zvynsetnosy: + zvyn
2014-06-27 13:54:39berker.peksagsetnosy: + berker.peksag
2014-06-26 18:59:00BreamoreBoysetnosy: + BreamoreBoy

messages: + msg221630
versions: + Python 3.4, Python 3.5, - Python 3.3
2011-09-03 17:59:54pitrousetnosy: + barry, r.david.murray
2011-08-28 18:01:55terry.reedysetcomponents: + Library (Lib), Tests
versions: + Python 3.3
2011-08-22 08:25:06tleeuwenburgcreate