classification
Title: modify configure.in to detect OpenBSD 5.x
Type: Stage: resolved
Components: Installation Versions: Python 3.2, Python 3.3, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: neologix, pitrou, python-dev, rpointel
Priority: normal Keywords: needs review, patch

Created on 2011-07-20 08:56 by rpointel, last changed 2011-07-22 21:56 by neologix. This issue is now closed.

Files
File name Uploaded Description Edit
configure_openbsd.diff neologix, 2011-07-22 20:55 review
Messages (7)
msg140724 - (view) Author: Remi Pointel (rpointel) * Date: 2011-07-20 08:56
Hi,
I tested to build Python 2.7 and Python 3.2.1 (it would be the same with others versions of Python) and it failed to build on OpenBSD 5.0 (beta version).

This is the diff to correctly work on OpenBSD 5.x:

--- configure.in.orig   Sat Jul  9 08:58:56 2011
+++ configure.in        Wed Jul 20 10:19:37 2011
@@ -320,7 +320,7 @@
     # As this has a different meaning on Linux, only define it on OpenBSD
     AC_DEFINE(_BSD_SOURCE, 1, [Define on OpenBSD to activate all library features])
     ;;
-  OpenBSD/4.@<:@789@:>@)
+  OpenBSD/4.@<:@789@:>@ | OpenBSD/5.*)
     # OpenBSD undoes our definition of __BSD_VISIBLE if _XOPEN_SOURCE is
     # also defined. This can be overridden by defining _BSD_SOURCE
     # As this has a different meaning on Linux, only define it on OpenBSD

Could you add this modification in the different versions of Python ?

Thanks a lot,

Remi.
msg140906 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2011-07-22 20:55
Patch attached (this one should also work with future major releases).
msg140907 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-07-22 21:02
Looks fine to me.
msg140914 - (view) Author: Roundup Robot (python-dev) Date: 2011-07-22 21:44
New changeset b24a2ccae56a by Charles-François Natali in branch '2.7':
Issue #12592: Make Python build on OpenBSD 5 (and future major releases).
http://hg.python.org/cpython/rev/b24a2ccae56a
msg140915 - (view) Author: Roundup Robot (python-dev) Date: 2011-07-22 21:48
New changeset 9c7f9d5841ff by Charles-François Natali in branch '3.2':
Issue #12592: Make Python build on OpenBSD 5 (and future major releases).
http://hg.python.org/cpython/rev/9c7f9d5841ff
msg140916 - (view) Author: Roundup Robot (python-dev) Date: 2011-07-22 21:51
New changeset 63de97ae832e by Charles-François Natali in branch 'default':
Merge - Issue #12592: Make Python build on OpenBSD 5 (and future major
http://hg.python.org/cpython/rev/63de97ae832e
msg140917 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2011-07-22 21:56
Patch committed.
Rémi, thanks for reporting this (and other OpenBSD-specific bugs :-).
History
Date User Action Args
2011-07-22 21:56:24neologixsetstatus: open -> closed
resolution: fixed
messages: + msg140917

stage: patch review -> resolved
2011-07-22 21:51:51python-devsetmessages: + msg140916
2011-07-22 21:48:38python-devsetmessages: + msg140915
2011-07-22 21:44:06python-devsetnosy: + python-dev
messages: + msg140914
2011-07-22 21:02:57pitrousetmessages: + msg140907
versions: + Python 3.3
2011-07-22 20:55:21neologixsetfiles: + configure_openbsd.diff

nosy: + neologix, pitrou
messages: + msg140906

keywords: + patch, needs review
stage: patch review
2011-07-20 08:56:21rpointelcreate