classification
Title: mailbox: use ASCII to read/write .mh_sequences files
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: haypo, jerub, python-dev, r.david.murray
Priority: normal Keywords: patch

Created on 2011-06-30 16:35 by haypo, last changed 2011-10-17 18:44 by haypo. This issue is now closed.

Files
File name Uploaded Description Edit
mailbox.patch haypo, 2011-06-30 16:35 review
Messages (3)
msg139502 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2011-06-30 16:35
The MH class uses the locale encoding to read and write .mh_sequences files. According to R. David Murray, ASCII can be safetly used instead. Extract of our discussion on IRC:

bitdancer> haypo: that's one of the cases where using locale
           is probably correct, even though I'd rather it
           used utf-8.
bitdancer> haypo: for nmh it is ASCII, for whatever that is worth.
bitdancer> I base this on the fact that the pick command says
           that a utf-8 character is invalid.
bitdancer> for a sequence name.
bitdancer> Which is the only thing other than numbers that goes
           in a sequences files.
Jerub> I concurr (was reading code)
msg145750 - (view) Author: Roundup Robot (python-dev) Date: 2011-10-17 18:44
New changeset 5ea81e4c58a7 by Victor Stinner in branch 'default':
Close #12454: The mailbox module is now using ASCII, instead of the locale
http://hg.python.org/cpython/rev/5ea81e4c58a7
msg145751 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2011-10-17 18:44
I kept Python 2.7 and 3.2 unchanged because I'm not completly sure that the fix is correct :-)
History
Date User Action Args
2011-10-17 18:44:43hayposetmessages: + msg145751
2011-10-17 18:44:00python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg145750

resolution: fixed
stage: resolved
2011-06-30 16:36:08hayposetnosy: + jerub
2011-06-30 16:35:52haypocreate