classification
Title: c99 code in mmapmodule
Type: compile error Stage: resolved
Components: Build Versions: Python 3.2, Python 3.3, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: rosslagerwall Nosy List: akitada, python-dev, rosslagerwall
Priority: normal Keywords: patch

Created on 2011-06-25 07:02 by akitada, last changed 2011-06-25 08:17 by rosslagerwall. This issue is now closed.

Files
File name Uploaded Description Edit
c89compat_mmap.patch akitada, 2011-06-25 07:02
Messages (3)
msg139020 - (view) Author: Akira Kitada (akitada) * Date: 2011-06-25 07:02
Modules/mmapmodule.c contains code that makes it incompatible with C89 compiler.

People using recent gcc can check this by running following commands.
 
    $ ./configure CFLAGS='-Wdeclaration-after-statement' && make

Attached patch fixes the issue.
(verified on Linux 2.6.39-2-amd64 with gcc 4.6.1)
msg139026 - (view) Author: Roundup Robot (python-dev) Date: 2011-06-25 08:14
New changeset c72dafb14c49 by Ross Lagerwall in branch '2.7':
Issue 12404: Remove C89 incompatible code from mmap module.
http://hg.python.org/cpython/rev/c72dafb14c49

New changeset 567236a7122c by Ross Lagerwall in branch '3.2':
Issue 12404: Remove C89 incompatible code from mmap module.
http://hg.python.org/cpython/rev/567236a7122c

New changeset 04182fa5255b by Ross Lagerwall in branch 'default':
Merge with 3.2 (Issue #12404).
http://hg.python.org/cpython/rev/04182fa5255b
msg139027 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2011-06-25 08:17
Thanks!
History
Date User Action Args
2011-06-25 08:17:03rosslagerwallsetstatus: open -> closed

assignee: rosslagerwall
versions: + Python 3.3
nosy: + rosslagerwall

messages: + msg139027
resolution: fixed
stage: resolved
2011-06-25 08:14:18python-devsetnosy: + python-dev
messages: + msg139026
2011-06-25 07:02:56akitadacreate