classification
Title: Check status returns in msilib.SummaryInformation.GetProperty()
Type: Stage:
Components: Versions:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: loewis, markm
Priority: normal Keywords: patch

Created on 2011-05-28 13:59 by markm, last changed 2011-05-28 14:23 by markm.

Files
File name Uploaded Description Edit
ensure_MsiSummaryInfoGetProperty_return_value_checked.patch markm, 2011-05-28 14:23 patch to check return value (and some tests)
Messages (2)
msg137132 - (view) Author: Mark Mc Mahon (markm) * Date: 2011-05-28 13:59 
Per Eric V. Smith's comment issue1104 (msg134976) the return value of the call MsiSummaryInfoGetProperty() in summary_getproperty() (pc\_msi.c) is only checked for the error return ERROR_MORE_DATA.

Other error values should be checked.
msg137134 - (view) Author: Mark Mc Mahon (markm) * Date: 2011-05-28 14:23 
I have added tests to the patch - but it's not easy to know what would cause an error in MsiSummaryInfoGetProperty which would trigger the new code.
History
Date User Action Args
2011-05-28 14:23:53markmsetfiles: + ensure_MsiSummaryInfoGetProperty_return_value_checked.patch
keywords: + patch
messages: + msg137134
2011-05-28 13:59:35markmcreate