This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Parser/asdl_c.py relies on mercurial repository revision
Type: Stage:
Components: Build Versions: Python 3.3
process
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, doko, r.david.murray, schmir
Priority: normal Keywords:

Created on 2011-05-23 07:49 by doko, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (9)
msg136591 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2011-05-23 07:49
when building without an hg repository present, the build fails with:

./Parser/asdl_c.py -h ../Include ../Parser/Python.asdl
Traceback (most recent call last):
  File "../Parser/asdl_c.py", line 1214, in <module>
    main(args[0])
  File "../Parser/asdl_c.py", line 1158, in main
    mod.version = get_file_revision(srcfile)
  File "../Parser/asdl_c.py", line 1142, in get_file_revision
    p = subprocess.Popen(args, stdout=subprocess.PIPE)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
make: *** [../Include/Python-ast.h] Error 1
msg136628 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2011-05-23 13:15
asdl_c.py should not be run during a non-checkout build, since the files it builds should already have been (re)built and checked in by the time a release is rolled.  IIUC The release building script is supposed to ensure the timestamps of the files are such that it won't be called.  What source are you doing the non-checkout build from?
msg136631 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2011-05-23 13:25
Indeed, Include/Python-ast.c and Python/Python-ast.c should be touched to avoid this.
msg136634 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2011-05-23 13:32
I'm building a snapshot package on a buildd, where a checkout is used (without the .hg directory). buildds don't have access to the network, and I don't want to package the .hg directory. So I assume I have to create a "release" tarball on my own, and build from that one. iirc I didn't see this behaviour with python3.2 when building pre alpha snapshot packages.
msg136635 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2011-05-23 13:36
It's true that Python use to be the only dependency for asdl_c.py, but now Mercurial is, too.
msg136662 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2011-05-23 15:28
And like Benjamin said, it should be enough to touch those two files.  You don't have to actually build a release tarball.
msg136663 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2011-05-23 15:29
ok, thanks. good enough
msg137389 - (view) Author: Ralf Schmitt (schmir) Date: 2011-05-31 21:16
http://bugs.python.org/issue12225 contains a patch.
msg137390 - (view) Author: Ralf Schmitt (schmir) Date: 2011-05-31 21:17
issue 12225 contains a patch.
History
Date User Action Args
2022-04-11 14:57:17adminsetgithub: 56361
2011-05-31 21:17:50schmirsetmessages: + msg137390
2011-05-31 21:16:37schmirsetnosy: + schmir
messages: + msg137389
2011-05-31 17:53:31r.david.murraylinkissue12225 superseder
2011-05-23 15:29:50dokosetstatus: open -> closed
resolution: not a bug
messages: + msg136663
2011-05-23 15:28:06r.david.murraysetmessages: + msg136662
2011-05-23 13:36:26benjamin.petersonsetmessages: + msg136635
2011-05-23 13:32:11dokosetmessages: + msg136634
2011-05-23 13:25:22benjamin.petersonsetmessages: + msg136631
2011-05-23 13:15:10r.david.murraysetnosy: + r.david.murray
messages: + msg136628
2011-05-23 10:09:23eric.araujosetnosy: + benjamin.peterson
2011-05-23 07:49:58dokocreate