test_logging does sometimes fail.

A recent example on Windows XP:
http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/4645/steps/test/logs/stdio

test test_logging failed -- Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_logging.py", line 3599, in test_rollover
    self.assertTrue(found, msg=msg)
AssertionError: False is not true : No rotated files found, went back 300 seconds

New changeset 54ffc01b6cc2 by Victor Stinner in branch 'default':
Issue #12151: test_logging writes debug messages to stderr, not stdout
http://hg.python.org/cpython/rev/54ffc01b6cc2

Victor, you just did what a recent discussion on python-dev strongly recommended not to do: you used ambiguous present tense in your commit message.  “test_logging writes debug messages to stderr, not stdout” does not say whether it is the buggy behavior (unambiguous example for that: “test_logging used to write debug messages to stderr, not stdout”) or the new, fixed behavior (“test_logging now writes debug messages to stderr, not stdout”).  You should use unambiguous phrasing like “make X do Y”, “fix Y with Z”, “don’t W when Z”.

Here's another (unrelated?) failure:

http://www.python.org/dev/buildbot/all/builders/x86%20Gentoo%203.x/builds/173/steps/test/logs/stdio

[ 43/355] test_logging
----------------------------------------
Traceback (most recent call last):
  File "/var/lib/buildslave/3.x.murray-gentoo/build/Lib/socketserver.py", line 582, in process_request_thread
    self.finish_request(request, client_address)
  File "/var/lib/buildslave/3.x.murray-gentoo/build/Lib/socketserver.py", line 323, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/var/lib/buildslave/3.x.murray-gentoo/build/Lib/socketserver.py", line 641, in __init__
    self.finish()
  File "/var/lib/buildslave/3.x.murray-gentoo/build/Lib/socketserver.py", line 713, in finish
    self.socket.sendto(self.wfile.getvalue(), self.client_address)
socket.error: [Errno 9] Bad file descriptor
test test_logging failed -- multiple errors occurred; run in verbose mode for details

New changeset 7980838e2f55 by Vinay Sajip in branch 'default':
Issue #12151: Added diagnostics to help diagnose intermittent socket errors.
http://hg.python.org/cpython/rev/7980838e2f55

New changeset 9ea03afc81f4 by Vinay Sajip in branch 'default':
Issue #12151: Correction to diagnostic code.
http://hg.python.org/cpython/rev/9ea03afc81f4

New changeset 1b1471d50b9e by Vinay Sajip in branch 'default':
Issue #12151: Test now ignores datagram socket errors after server is closed.
http://hg.python.org/cpython/rev/1b1471d50b9e

The last change appears to have fixed the problem; AFAIK there have been no test_logging failures on the buildbots for several days.

> The last change appears to have fixed the problem; 
> AFAIK there have been no test_logging failures on the buildbots 
> for several days.

Great job, thanks!

A similar failure to msg136576 has cropped up on the Windows 7 bot:

http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%203.x/builds/4469/steps/test/logs/stdio

> A similar failure to msg136576 has cropped up on the Windows 7 bot:

> 
> http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%203.x/builds/4469/steps/test/logs/stdio

Right. Not making excuses, but this one is rather hard to find, as it's pretty hard to reproduce. That's why I haven't made any progress :-(

> Not making excuses, but this one is rather hard to find, as it's pretty hard to reproduce. That's why I haven't made any progress :-(

Yeah, not having a reproducible test case is quite a pain.

(I suppose this should be reopened if the failure is still happening...)

New changeset ce0b9b1328d4 by Vinay Sajip in branch 'default':
Added additional diagnostics to help with #12151.
http://hg.python.org/cpython/rev/ce0b9b1328d4

New changeset 0457fb8bf39c by Vinay Sajip in branch 'default':
Added more diagnostics for diagnosing #12151.
http://hg.python.org/cpython/rev/0457fb8bf39c

New changeset a495c41c1e13 by Vinay Sajip in branch 'default':
Issue #12151: Added more info to diagnostics.
http://hg.python.org/cpython/rev/a495c41c1e13

After an increase to a delay in the test(1.01 -> 1.1 seconds) the problem seems to have disappeared. So closing for now, since this error appears not to have occurred over a period of a few days.