This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_packaging monkeypatches httplib
Type: Stage: resolved
Components: Distutils2, Tests Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: tarek Nosy List: alexis, eric.araujo, pitrou, python-dev, tarek
Priority: normal Keywords:

Created on 2011-05-19 11:36 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (4)
msg136274 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-05-19 11:36
======================================================================
ERROR: test_https (test.test_urllib2_localnet.TestUrlopen)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\Buildslave\3.x.moore-windows\build\lib\test\test_urllib2_localnet.py", line 457, in test_https
    data = self.urlopen("https://localhost:%s/bizarre" % handler.port)
  File "D:\Buildslave\3.x.moore-windows\build\lib\test\test_urllib2_localnet.py", line 364, in urlopen
    f = urllib.request.urlopen(url, data, **kwargs)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 138, in urlopen
    return opener.open(url, data, timeout)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 369, in open
    response = self._open(req, data)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 387, in _open
    '_open', req)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 347, in _call_chain
    result = func(*args)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 1179, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 1116, in do_open
    h = http_class(host, timeout=req.timeout, **http_conn_args)
TypeError: https_conn_wrapper() got an unexpected keyword argument 'check_hostname'

======================================================================
ERROR: test_https_with_cafile (test.test_urllib2_localnet.TestUrlopen)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\Buildslave\3.x.moore-windows\build\lib\test\test_urllib2_localnet.py", line 465, in test_https_with_cafile
    cafile=CERT_localhost)
  File "D:\Buildslave\3.x.moore-windows\build\lib\test\test_urllib2_localnet.py", line 364, in urlopen
    f = urllib.request.urlopen(url, data, **kwargs)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 138, in urlopen
    return opener.open(url, data, timeout)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 369, in open
    response = self._open(req, data)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 387, in _open
    '_open', req)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 347, in _call_chain
    result = func(*args)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 1179, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "D:\Buildslave\3.x.moore-windows\build\lib\urllib\request.py", line 1116, in do_open
    h = http_class(host, timeout=req.timeout, **http_conn_args)
TypeError: https_conn_wrapper() got an unexpected keyword argument 'check_hostname'
msg136277 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-05-19 11:39
$ grep -r https_conn_wrapper *
Lib/packaging/tests/test_command_upload_docs.py:146:        def https_conn_wrapper(*args):
Lib/packaging/tests/test_command_upload_docs.py:152:        upload_docs_mod.http.client.HTTPSConnection = https_conn_wrapper
msg136278 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-05-19 11:46
New changeset 56aa0aca7186 by Tarek Ziade in branch 'default':
Issue #12109 fixing typo in packaging's test_command_upload_docs
http://hg.python.org/cpython/rev/56aa0aca7186
msg136284 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-05-19 12:35
Looks good here, thank you :)
History
Date User Action Args
2022-04-11 14:57:17adminsetgithub: 56318
2011-05-19 12:35:02pitrousetstatus: open -> closed
resolution: fixed
messages: + msg136284

stage: needs patch -> resolved
2011-05-19 11:46:56python-devsetnosy: + python-dev
messages: + msg136278
2011-05-19 11:39:36pitrousetmessages: + msg136277
2011-05-19 11:37:34pitroulinkissue12110 superseder
2011-05-19 11:36:44pitroucreate