PyZipFile.writepy gives internal error on syntax errors in files it processes.

For example, in the attached test case:
Traceback (most recent call last):
  File "C:\tfs\SDKS\python\Python32\lib\py_compile.py", line 119, in compile
    optimize=optimize)
  File "test_zipfile_error_bad_syntax.py", line 1
    syntax error
               ^
SyntaxError: invalid syntax

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\tfs\SDKS\python\Python32\lib\zipfile.py", line 1393, in _compile
    py_compile.compile(file, doraise=True, optimize=optimize)
  File "C:\tfs\SDKS\python\Python32\lib\py_compile.py", line 123, in compile
    raise py_exc
py_compile.PyCompileError:   File "test_zipfile_error_bad_syntax.py", line 1
    syntax error
               ^
SyntaxError: invalid syntax


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "test_zipfile_error.py", line 7, in <module>
    pzf.writepy(PYFILE)
  File "C:\tfs\SDKS\python\Python32\lib\zipfile.py", line 1376, in writepy
    fname, arcname = self._get_codename(pathname[0:-3], basename)
  File "C:\tfs\SDKS\python\Python32\lib\zipfile.py", line 1428, in _get_codename

    if _compile(file_py):
  File "C:\tfs\SDKS\python\Python32\lib\zipfile.py", line 1395, in _compile
    print(err.msg)
NameError: global name 'err' is not defined

Around zipfile.py:1395 
in PyZipFile._get_codename _compile
            try:
                py_compile.compile(file, doraise=True, optimize=optimize)
            except py_compile.PyCompileError as error:
                print(err.msg)
                return False

The print should be printing error.msg not err.msg

Could you incorporate the test into Lib/test/test_zipfile?

Thanks!

I've attached a patch to test_zipfile.py. I noticed that it writes out the error to stdout not stderr; I don't know if this is the desired behaviour.

The patches look good to me, except that `self.assertIn('mod1.py', names)` can be used instead `self.assertTrue('mod1.py' in names)`.

Ben Morgan, can you please submit a contributor form?

http://python.org/psf/contrib/contrib-form/
http://python.org/psf/contrib/

Okay, I've emailed a contributor agreement.

Ben, can you please resend your agreement?

I've sent it again.

New changeset 3a1ac42435f9 by Serhiy Storchaka in branch '3.2':
Issue #12004: Fix an internal error in PyZipFile when writing an invalid
http://hg.python.org/cpython/rev/3a1ac42435f9

New changeset 678320c7f63d by Serhiy Storchaka in branch '3.3':
Issue #12004: Fix an internal error in PyZipFile when writing an invalid
http://hg.python.org/cpython/rev/678320c7f63d

New changeset e24fd2c35d27 by Serhiy Storchaka in branch 'default':
Issue #12004: Fix an internal error in PyZipFile when writing an invalid
http://hg.python.org/cpython/rev/e24fd2c35d27

Thank you for the patch.