Created on 2011-04-10 21:11 by rhettinger, last changed 2012-06-07 18:36 by belopolsky. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue11823.diff | belopolsky, 2011-04-11 16:08 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg133481 - (view) | Author: Raymond Hettinger (rhettinger) *  |
Date: 2011-04-10 21:11 | |
The argument to CALL_FUNCTION is overloaded to show both the number of positional arguments and keyword arguments (shifted by 8-bits):
>>> dis("foo(10, opt=True)")
1 0 LOAD_NAME 0 (foo)
3 LOAD_CONST 0 (10)
6 LOAD_CONST 1 ('opt')
9 LOAD_CONST 2 (True)
12 CALL_FUNCTION 257
15 RETURN_VALUE
It is not obvious that the 257 argument causes three stack arguments to be popped.
The disassembly should add a parenthetical to explain the composition:
>>> dis("foo(10, opt=True)")
1 0 LOAD_NAME 0 (foo)
3 LOAD_CONST 0 (10)
6 LOAD_CONST 1 ('opt')
9 LOAD_CONST 2 (True)
12 CALL_FUNCTION 257 (1 positional, 1 keyword pair)
15 RETURN_VALUE
|
|||
| msg133534 - (view) | Author: Alexander Belopolsky (belopolsky) * |
Date: 2011-04-11 16:08 | |
I am posting an unfinished patch (needs additional tests and possibly documentation) to get feedback on whether it would make sense to wait for issue11816 refactoring before implementing this. Note the code duplication between disassemble and _disassemble_bytes. I am also not happy about the need for another constant exported from opcode. |
|||
| msg133638 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2011-04-13 02:07 | |
Looks good. Please apply. |
|||
| msg162485 - (view) | Author: Alexander Belopolsky (belopolsky) * |
Date: 2012-06-07 18:14 | |
Bumping priority as a reminder to get this in. |
|||
| msg162487 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-06-07 18:29 | |
New changeset 22dc0a433b0e by Alexander Belopolsky in branch 'default': Issue #11823: disassembly now shows argument counts on calls with keyword args http://hg.python.org/cpython/rev/22dc0a433b0e |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-06-07 18:36:25 | belopolsky | set | status: open -> closed |
| 2012-06-07 18:33:03 | belopolsky | set | stage: needs patch -> resolved type: behavior -> enhancement versions: - Python 3.1, Python 2.7, Python 3.2 |
| 2012-06-07 18:29:30 | python-dev | set | nosy:
+ python-dev messages: + msg162487 |
| 2012-06-07 18:14:42 | belopolsky | set | priority: normal -> high messages: + msg162485 |
| 2011-04-13 02:07:19 | rhettinger | set | versions:
+ Python 3.1, Python 2.7, Python 3.2 type: enhancement -> behavior title: disassembly needs to argument counts on calls with keyword args -> disassembly needs argument counts on calls with keyword args messages: + msg133638 assignee: belopolsky resolution: accepted |
| 2011-04-11 16:08:51 | belopolsky | set | files:
+ issue11823.diff nosy: + belopolsky messages: + msg133534 keywords: + patch |
| 2011-04-10 21:35:43 | daniel.urban | set | nosy:
+ daniel.urban |
| 2011-04-10 21:17:51 | pitrou | set | keywords:
+ easy stage: needs patch |
| 2011-04-10 21:11:39 | rhettinger | create | |