This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Better core dev guidelines for committing submitted patches
Type: Stage: resolved
Components: Devguide Versions: 3rd party
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ncoghlan Nosy List: belopolsky, eric.araujo, nadeem.vawda, ncoghlan, r.david.murray, terry.reedy
Priority: normal Keywords:

Created on 2011-04-07 12:46 by ncoghlan, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg133212 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2011-04-07 12:46
Based on a core-mentoring thread, a couple more points for:
http://docs.python.org/devguide/committing.html#handling-other-s-code

Attribution:
- add to Misc/ACKS if they aren't already there (and didn't add themselves in their patch)
- mention "Patch by <x>" in the NEWS entry and the checkin message*
- If I had to substantially change or fix a patch, I'll usually amend the acknowledgement to "Initial patch by <x>"

*(If I forget to say something in the checkin message, I generally don't worry about it - ACKS and NEWS are the important ones)

Contributor Licensing Agreements
- it's unlikely bug fixes will require a CLA unless they touch a *lot* of code
- new features often get into CLA-preferred territory, as the associated comments, docstrings and documentation are far more likely to reach a copyrightable standard
- for sprints, we now just collect CLAs as a matter of course, since there isn't any real inconvenience in doing so
msg133240 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2011-04-07 17:33
I had some of the same questions, so I agree this would be a good addition.
msg133319 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-04-08 15:48
+1
msg138633 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2011-06-19 15:02
Enhanced committer guidelines: http://hg.python.org/devguide/rev/774fb024b152
msg138641 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2011-06-19 16:26
Note that the older tradition was to *not* mention the contributor in NEWS (NEWS was just technical notes), but to mention them in the checkin message (and What's New, for things that make the What's New cut).  However, since we can't edit checkin messages post-commit like we could with SVN, I suppose this new convention (that some people have been following since well before the switchover...) is more practical.
History
Date User Action Args
2022-04-11 14:57:15adminsetgithub: 56004
2011-06-19 16:26:21r.david.murraysetnosy: + r.david.murray
messages: + msg138641
2011-06-19 15:03:54ncoghlansetstatus: open -> closed
resolution: fixed
stage: needs patch -> resolved
2011-06-19 15:02:53ncoghlansetmessages: + msg138633
2011-04-08 15:48:30eric.araujosetnosy: + eric.araujo

messages: + msg133319
versions: + 3rd party
2011-04-07 17:33:23terry.reedysetnosy: + terry.reedy

messages: + msg133240
stage: needs patch
2011-04-07 16:51:14belopolskysetnosy: + belopolsky
2011-04-07 14:42:06nadeem.vawdasetnosy: + nadeem.vawda
2011-04-07 12:46:53ncoghlancreate