This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_ftplib failure in test for source_address
Type: behavior Stage: needs patch
Components: Library (Lib), Tests Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: giampaolo.rodola Nosy List: giampaolo.rodola, jesstess, pitrou
Priority: normal Keywords:

Created on 2011-04-03 16:06 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg132849 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-04-03 16:06
See http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%203.x/builds/2475/steps/test/logs/stdio


test test_ftplib failed -- Traceback (most recent call last):
  File "D:\Buildslave\3.x.moore-windows\build\lib\test\test_ftplib.py", line 622, in test_source_address_passive_connection
    with self.client.transfercmd('list') as sock:
  File "D:\Buildslave\3.x.moore-windows\build\lib\ftplib.py", line 379, in transfercmd
    return self.ntransfercmd(cmd, rest)[0]
  File "D:\Buildslave\3.x.moore-windows\build\lib\ftplib.py", line 344, in ntransfercmd
    source_address=self.source_address)
  File "D:\Buildslave\3.x.moore-windows\build\lib\socket.py", line 407, in create_connection
    raise err
  File "D:\Buildslave\3.x.moore-windows\build\lib\socket.py", line 397, in create_connection
    sock.bind(source_address)
socket.error: [Errno 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted
msg132852 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-04-03 16:20
10048 is errno.EADDRINUSE.
msg132860 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-04-03 16:34
http://hg.python.org/cpython/rev/8a2d848244a2
msg136734 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2011-05-24 10:58
Is this fixed?
msg216844 - (view) Author: Jessica McKellar (jesstess) * (Python triager) Date: 2014-04-19 05:31
Antoine, thanks for the patch, and Giampaolo, thanks for the ping.

I confirmed that http://hg.python.org/cpython/rev/8a2d848244a2 does address the issue:

Before the patch, if another process bound to the port selected for the test before the test ran, the test would error out.

After the patch, if this race happens the test is skipped instead.

Anecdotally from local tests and from looking at recent buildbot builds, the test does generally run (so we don't have a problem with it skipping all the time and the behavior not getting tested).

=> Closing as resolved.
History
Date User Action Args
2022-04-11 14:57:15adminsetgithub: 55957
2014-04-19 05:31:11jesstesssetstatus: open -> closed

nosy: + jesstess
messages: + msg216844

resolution: fixed
2011-05-24 10:58:32giampaolo.rodolasetmessages: + msg136734
2011-04-03 16:46:30pitrousetmessages: + msg132860
2011-04-03 16:20:10pitrousetmessages: + msg132852
2011-04-03 16:06:54pitroucreate