➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-03-14 20:46 by denversc, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| fileinput_unittests_v2.patch | denversc, 2011-03-14 20:58 | added tests for fileinput.close() | review | |
| fileinput_unittests_v3.patch | denversc, 2011-03-14 21:16 | added tests for fileinput.nextfile() | review | |
| fileinput_unittests_v5.patch | denversc, 2011-03-14 21:48 | added tests for fileinput functions lineno, filelineno, fileno, isfirstline, isstdin | review | |
| fileinput_unittests_v6.patch | denversc, 2011-03-14 22:05 | factored out some shared "mock" logic | review | |
| fileinput_unittests_v7.patch | denversc, 2011-03-14 22:12 | added tests for the scenario where files=[] is specified to FileInput.__init__() | review | |
| fileinput_unittests_v8.patch | denversc, 2011-03-14 22:28 | added tests for FileInput.__getitem__() | review | |
| fileinput_unittests_v9.patch | denversc, 2011-03-14 23:00 | added tests for a corner case of FileInput.nextfile() where os.unlink() raises OSError | review | |
| fileinput_unittests_v10.patch | denversc, 2011-03-15 00:07 | added corner case tests when OSError is raised inside FileInput.readline() | review | |
| fileinput_unittests_v11.patch | denversc, 2011-03-15 00:19 | re-implemented commented tests for FileInput's "openhook" | review | |
| fileinput_unittests_v12.patch | denversc, 2011-03-15 00:34 | added test for FileInput.fileno() when _file.fileno() raises ValueError | review | |
| fileinput_unittests_v12.patch | denversc, 2011-03-15 01:13 | added tests for fileinput.hook_compressed() | review | |
| fileinput_unittests_v13.patch | denversc, 2011-03-15 03:11 | added tests for fileinput.hook_encoded() | review | |
| Messages (5) | |||
|---|---|---|---|
| msg130895 - (view) | Author: Denver Coneybeare (denversc) * | Date: 2011-03-14 20:46 | |
As part of the CPython sprints at PyCon 2011 I am improving the unit test coverage for the fileinput module. Primarily, this will be adding unit tests for the global functions, which right now are almost completely untested. I will be adding incremental patches and will update once my work is complete, when the final patch can be committed. |
|||
| msg130949 - (view) | Author: Denver Coneybeare (denversc) * | Date: 2011-03-15 03:33 | |
fileinput_unittests_v13.patch is the final patch. Test coverage increased from 65% to 93% with this patch. The only code left untested is fileinput._test(), which by its name suggests that testing is not required. |
|||
| msg130977 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2011-03-15 14:29 | |
New changeset f2e04ce75f0b by briancurtin in branch 'default': Fix #11509. Significantly increase test coverage for fileinput. http://hg.python.org/cpython/rev/f2e04ce75f0b |
|||
| msg130978 - (view) | Author: Brian Curtin (brian.curtin) *  |
Date: 2011-03-15 14:31 | |
Many thanks for the patch, Denver! |
|||
| msg130985 - (view) | Author: Roundup Robot (python-dev) |
Date: 2011-03-15 15:51 | |
New changeset 9448691fe084 by briancurtin in branch 'default': Add news item for #11509. http://hg.python.org/cpython/rev/9448691fe084 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:14 | admin | set | github: 55718 |
| 2011-03-15 15:51:36 | python-dev | set | nosy:
michael.foord, brian.curtin, denversc, python-dev messages: + msg130985 |
| 2011-03-15 14:31:41 | brian.curtin | set | status: open -> closed nosy: michael.foord, brian.curtin, denversc, python-dev messages: + msg130978 assignee: brian.curtin resolution: fixed stage: resolved |
| 2011-03-15 14:29:59 | python-dev | set | nosy:
+ python-dev messages: + msg130977 |
| 2011-03-15 03:33:29 | denversc | set | nosy:
michael.foord, brian.curtin, denversc messages: + msg130949 |
| 2011-03-15 03:11:43 | denversc | set | files:
+ fileinput_unittests_v13.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-15 01:13:09 | denversc | set | files:
+ fileinput_unittests_v12.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-15 00:34:02 | denversc | set | files:
+ fileinput_unittests_v12.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-15 00:19:10 | denversc | set | files:
+ fileinput_unittests_v11.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-15 00:07:07 | denversc | set | files:
+ fileinput_unittests_v10.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 23:00:32 | denversc | set | files:
+ fileinput_unittests_v9.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 22:28:58 | denversc | set | files:
+ fileinput_unittests_v8.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 22:28:05 | denversc | set | files:
- fileinput_unittests_v1.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 22:12:10 | denversc | set | files:
+ fileinput_unittests_v7.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 22:05:23 | denversc | set | files:
+ fileinput_unittests_v6.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 21:48:40 | denversc | set | files:
+ fileinput_unittests_v5.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 21:16:19 | denversc | set | files:
+ fileinput_unittests_v3.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 20:58:49 | denversc | set | files:
+ fileinput_unittests_v2.patch nosy: michael.foord, brian.curtin, denversc |
| 2011-03-14 20:46:37 | denversc | create | |