Created on 2011-03-14 16:07 by rswilson, last changed 2011-03-14 22:56 by ronaldoussoren. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| proxy_bypass_osx.diff | rswilson, 2011-03-14 16:07 | review | ||
| proxy_bypass_osx_w_tests.diff | rswilson, 2011-03-14 20:08 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg130841 - (view) | Author: Scott Wilson (rswilson) * | Date: 2011-03-14 16:07 | |
Fixes a bug in the os x proxy bypass code for fully qualified IP addresses in the proxy exception list. Tests that fail on os x without this patch: test_urllib2.HandlerTests.test_proxy_https test_urllib2.HandlerTests.test_proxy_https_proxy_authorization Will create a separate issue to improve test coverage in this area. |
|||
| msg130888 - (view) | Author: Scott Wilson (rswilson) * | Date: 2011-03-14 20:08 | |
This patch adds test coverage to the osx proxy bypass code and includes the previous one line patch. Also adds a test for the proxy_no=* case. |
|||
| msg130918 - (view) | Author: Ronald Oussoren (ronaldoussoren) *  |
Date: 2011-03-14 22:07 | |
Patch looks great, I'll commit shortly. Thanks for the patch. |
|||
| msg130921 - (view) | Author: Roundup Robot (python-dev) | Date: 2011-03-14 22:54 | |
New changeset 682903e066db by Ronald Oussoren in branch '3.1': Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified IP addresses in the proxy exception list http://hg.python.org/cpython/rev/682903e066db New changeset aafb0fed1811 by Ronald Oussoren in branch '3.2': Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified IP addresses in the proxy exception list. http://hg.python.org/cpython/rev/aafb0fed1811 New changeset 166dcfc2c0fa by Ronald Oussoren in branch 'default': Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified IP addresses in the proxy exception list. http://hg.python.org/cpython/rev/166dcfc2c0fa New changeset 8f0756010720 by Ronald Oussoren in branch '2.7': Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified http://hg.python.org/cpython/rev/8f0756010720 |
|||
| msg130922 - (view) | Author: Ronald Oussoren (ronaldoussoren) * |
Date: 2011-03-14 22:56 | |
The patch got merged. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-03-14 22:56:10 | ronaldoussoren | set | status: open -> closed nosy: ronaldoussoren, orsenthil, python-dev, rswilson messages: + msg130922 resolution: fixed stage: resolved |
| 2011-03-14 22:54:26 | python-dev | set | nosy:
+ python-dev messages: + msg130921 |
| 2011-03-14 22:07:56 | ronaldoussoren | set | nosy:
+ ronaldoussoren messages: + msg130918 |
| 2011-03-14 20:08:53 | rswilson | set | files:
+ proxy_bypass_osx_w_tests.diff messages: + msg130888 |
| 2011-03-14 16:38:50 | rswilson | set | nosy:
+ orsenthil, - ronaldoussoren type: behavior |
| 2011-03-14 16:07:17 | rswilson | create | |