classification
Title: test_zipfile.test_unicode_filenames should be skipped of no zlib
Type: behavior Stage: committed/rejected
Components: Tests Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, nessita, python-dev
Priority: normal Keywords: patch

Created on 2011-03-14 15:39 by nessita, last changed 2011-03-14 17:00 by ezio.melotti. This issue is now closed.

Files
File name Uploaded Description Edit
pycon-issue11498.patch nessita, 2011-03-14 15:41 review
Messages (4)
msg130831 - (view) Author: Natalia B. Bidart (nessita) * Date: 2011-03-14 15:39
When running the test suite, if zlib is not available, we get this failure:

[1/1] test_zipfile
test test_zipfile failed -- Traceback (most recent call last):
  File "/home/nessita/pycon/sprint/cpython/Lib/test/test_zipfile.py", line 498, in test_unicode_filenames
    zipfp.open(name).close()
  File "/home/nessita/pycon/sprint/cpython/Lib/zipfile.py", line 978, in open
    close_fileobj=not self._filePassed)
  File "/home/nessita/pycon/sprint/cpython/Lib/zipfile.py", line 487, in __init__
    self._decompressor = zlib.decompressobj(-15)
AttributeError: 'NoneType' object has no attribute 'decompressobj'
1 test failed:
    test_zipfile
msg130832 - (view) Author: Natalia B. Bidart (nessita) * Date: 2011-03-14 15:41
Trivial patch to skip the aforementioned test.
msg130836 - (view) Author: Roundup Robot (python-dev) Date: 2011-03-14 15:57
New changeset 89af3880ca57 by Eric V. Smith in branch 'default':
Skip test if zlib not present. Closes #11498. Patch by Natalia B. Bidart.
http://hg.python.org/cpython/rev/89af3880ca57
msg130857 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2011-03-14 16:59
I fixed it in 3.2 too in d2689ed3dc83.
Thanks for the patch!
History
Date User Action Args
2011-03-14 17:00:16ezio.melottisetstatus: open -> closed
type: crash -> behavior
resolution: fixed
stage: committed/rejected
2011-03-14 16:59:52ezio.melottisetstatus: closed -> open

messages: + msg130857
resolution: fixed -> (no value)
stage: committed/rejected -> (no value)
2011-03-14 15:57:28python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg130836

resolution: fixed
stage: committed/rejected
2011-03-14 15:41:43nessitasetfiles: + pycon-issue11498.patch

messages: + msg130832
keywords: + patch
2011-03-14 15:41:02ezio.melottisetassignee: ezio.melotti

nosy: + ezio.melotti
2011-03-14 15:39:46nessitacreate