classification
Title: Cookie.py produces invalid code
Type: Stage:
Components: Extension Modules Versions: Python 2.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: georg.brandl, georg.brandl, sdahlbac
Priority: normal Keywords:

Created on 2005-01-25 09:04 by sdahlbac, last changed 2005-06-26 21:03 by georg.brandl. This issue is now closed.

Files
File name Uploaded Description Edit
Cookie.patch.py sdahlbac, 2005-01-25 09:04 new version of js_output function
Messages (2)
msg24029 - (view) Author: Simon Dahlbacka (sdahlbac) Date: 2005-01-25 09:04 
The code in js_output in the Morsel class in Cookie.py
produces invalid code, the scripting language should be
specified by mimetype and not by language as per
http://www.w3.org/TR/html401/interact/scripts.html

also, the javascript line is missing an ending semi-colon

attached a "patch" (new version of the function in
question)

present at least in 2.3 but still broken in current cvs 

A related matter: the existing documentation is poor,
only after a substantial amount of code reading and
googling I found out how to set attributes such as
expires and path.
msg24030 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2005-06-26 21:03 
Logged In: YES 
user_id=1188172

Thanks for the report, fixed as of Lib/Cookie.py r1.18.

I do not backport this as some code might rely on the
language HTML attribute.
History
Date User Action Args
2005-01-25 09:04:05sdahlbaccreate