classification
Title: tarfile.ExFileObject iterators
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: alanmcintyre, loewis, mitchchapman
Priority: normal Keywords: patch

Created on 2005-01-23 21:58 by mitchchapman, last changed 2005-03-03 08:18 by loewis. This issue is now closed.

Files
File name Uploaded Description Edit
tarfile_diffs.txt mitchchapman, 2005-01-23 21:58 Patches for Lib/tarfile.py, Lib/test/test_tarfile.py, with diffs
Messages (3)
msg47602 - (view) Author: Mitch Chapman (mitchchapman) Date: 2005-01-23 21:58 
Since Python 2.2 it has been possible to iterate over the lines of a 
file object (PEP 234).  This patch provides line-by-line iterators for 
TarFile.extractfile.

The attachment contains forward diffs for both Lib/tarfile.py and 
Lib/test/test_tarfile.py.
msg47603 - (view) Author: Alan McIntyre (alanmcintyre) (Python committer) Date: 2005-02-27 06:10 
Logged In: YES 
user_id=1115903

The patch seems to work as advertised; all regression tests
pass when run against 2.5a0 (CVS HEAD, built with MSVC .NET)
+ this patch on Windows XP.  

Improving the file-likeness of ExFileObject seems like a
good idea to me, so I'm all for seeing this get accepted. :)
msg47604 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2005-03-03 08:18 
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as

tarfile.py 1.24
test_tarfile.py 1.17
NEWS 1.1250
History
Date User Action Args
2005-01-23 21:58:16mitchchapmancreate