classification
Title: Duplicate entries in IDLE "Recent Files" menu item on OS X
Type: behavior Stage: resolved
Components: Versions: Python 3.1, Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ned.deily Nosy List: kbk, ned.deily, python-dev
Priority: normal Keywords: patch

Created on 2011-01-24 18:35 by ned.deily, last changed 2012-05-29 17:53 by ned.deily. This issue is now closed.

Files
File name Uploaded Description Edit
issue_idle_dup_recent.patch ned.deily, 2011-01-24 18:35
Messages (3)
msg126941 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-24 18:35
When IDLE is run with an OS X Aqua Tk (Carbon 8.4 or Cocoa 8.5), using the File -> Recent Files menu item to open a previously used file causes that file to show up a second time in the updated menu item and with the same keyboard shortcut.  With X11-based Tk on OS X, no duplicate is seen.  The problem stems from a difference in the way the Tk versions generate sub menus.  With the X11 Tk the sub menu appears to start with a separator in menu index 0 and the first file is added in index 1.  With Aqua Tk, there is no separator and the first file is in index 0.  The code in IDLE to update the menu deletes from 1 to END so, with Aqua Tk, the file name inserted into index 0 is not removed.  The attached patch fixes the problem with Aqua Tk and appears to cause no problems with a current X11 Tk 8.5 on OS X.  Before committing it, though, it should be tested on Windows, which I'm not currently set up to do.
msg161904 - (view) Author: Roundup Robot (python-dev) Date: 2012-05-29 17:52
New changeset 3108331c88ec by Ned Deily in branch '2.7':
Issue #10997: Prevent a duplicate entry in IDLE's "Recent Files" menu.
http://hg.python.org/cpython/rev/3108331c88ec

New changeset 64a7fae544a6 by Ned Deily in branch '3.2':
Issue #10997: Prevent a duplicate entry in IDLE's "Recent Files" menu.
http://hg.python.org/cpython/rev/64a7fae544a6

New changeset cb7421cdaec4 by Ned Deily in branch 'default':
Issue #10997: merge from 3.2
http://hg.python.org/cpython/rev/cb7421cdaec4
msg161905 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-05-29 17:53
Patch applied for 2.7.4, 3.2.4, and 3.3.0.
History
Date User Action Args
2012-05-29 17:53:47ned.deilysetstatus: open -> closed
resolution: fixed
messages: + msg161905

stage: patch review -> resolved
2012-05-29 17:52:18python-devsetnosy: + python-dev
messages: + msg161904
2011-01-24 18:50:35ned.deilysetnosy: + kbk
2011-01-24 18:35:30ned.deilysetstage: patch review
2011-01-24 18:35:15ned.deilycreate