➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-01-21 18:46 by eric.araujo, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (2) | |||
|---|---|---|---|
| msg126765 - (view) | Author: Éric Araujo (eric.araujo) *  |
Date: 2011-01-21 18:46 | |
Some comments. Haven’t tested the patch yet. http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py#newcode2507 Lib/pydoc.py:2507: <div style='overflow:auto'> Does this work fine with common Web browsers, including not-most-recent versions, and various resolutions? (“fine” being defined as “not worse than before the patch”) http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py#newcode2591 Lib/pydoc.py:2591: return '<a href="topic?key=%s.html">%s</a>' % (name, name) I see no reason for polluting the key value with “.html” http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py#newcode2713 Lib/pydoc.py:2713: raise TypeError('unknown content type %r' % ([url, content_type])) You can remove the extraneous parens around the list. http://codereview.appspot.com/4090042/diff/1/Lib/test/test_pydoc.py File Lib/test/test_pydoc.py (right): http://codereview.appspot.com/4090042/diff/1/Lib/test/test_pydoc.py#newcode431 Lib/test/test_pydoc.py:431: ("", "PyDoc: Index of Modules"), I’m not sure “PyDoc” is better than “Python”. What about “Python Doc”? Very clear and still short. http://codereview.appspot.com/4090042/ |
|||
| msg126766 - (view) | Author: Éric Araujo (eric.araujo) * |
Date: 2011-01-21 18:48 | |
One day, email from rietveld will go to the right roundup report. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:11 | admin | set | github: 55184 |
| 2011-01-29 19:15:38 | eric.araujo | set | messages: - msg127466 |
| 2011-01-29 19:12:16 | eric.araujo | set | messages: + msg127466 |
| 2011-01-22 19:00:15 | eric.araujo | set | messages: - msg126847 |
| 2011-01-22 18:29:47 | eric.araujo | set | messages: + msg126847 |
| 2011-01-21 18:48:31 | eric.araujo | set | status: open -> closed messages: + msg126766 resolution: not a bug stage: resolved |
| 2011-01-21 18:46:03 | eric.araujo | create | |