➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: use assertIsNone(...) instead of assertEquals(None, ...)
Type: Stage: patch review
Components: Tests Versions: Python 3.3
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: sandro.tosi Nosy List: pitrou, r.david.murray, rhettinger, sandro.tosi
Priority: normal Keywords: patch

Created on 2011-01-04 13:48 by sandro.tosi, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
use_assertIsNone-py3k.patch sandro.tosi, 2011-01-04 13:48
Messages (3)
msg125317 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2011-01-04 13:48 
Hello, after I saw that in issue9554, I created a small patch to replace all

  assertEquals(None, ...)

with

  assertIsNone(...)

It's not rocket science, but I think it makes test suite "better" and leverage new unittest features.

Cheers,
Sandro
msg125319 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-01-04 13:55 
Looks good.
msg125505 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2011-01-06 05:34 
Applied in r87783.
History
Date User Action Args
2022-04-11 14:57:10adminsetgithub: 55034
2011-01-06 05:34:46rhettingersetstatus: open -> closed

nosy: + rhettinger
messages: + msg125505

resolution: accepted
2011-01-04 13:55:56pitrousetnosy: + r.david.murray, pitrou
messages: + msg125319
2011-01-04 13:48:59sandro.tosicreate