Created on 2010-11-28 23:38 by jwilk, last changed 2014-03-25 09:24 by merwok. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue10571.diff | jwilk, 2010-11-29 15:05 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg122747 - (view) | Author: Jakub Wilk (jwilk) | Date: 2010-11-28 23:38 | |
$ python3 --version
Python 3.1.3
$ python3 setup.py bdist upload --sign
[snip]
Traceback (most recent call last):
File "setup.py", line 71, in <module>
cmdclass = dict(build_py=build_py)
File "/usr/local/lib/python3.1/distutils/core.py", line 149, in setup
dist.run_commands()
File "/usr/local/lib/python3.1/distutils/dist.py", line 919, in run_commands
self.run_command(cmd)
File "/usr/local/lib/python3.1/distutils/dist.py", line 938, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.1/distutils/command/upload.py", line 66, in run
self.upload_file(command, pyversion, filename)
File "/usr/local/lib/python3.1/distutils/command/upload.py", line 155, in upload_file
body.write(value)
TypeError: 'str' does not support the buffer interface
Without --sign it works just fine.
|
|||
| msg122802 - (view) | Author: Éric Araujo (merwok) *  |
Date: 2010-11-29 14:10 | |
Thank you for the report. Do you want to propose a patch? |
|||
| msg122807 - (view) | Author: Jakub Wilk (jwilk) | Date: 2010-11-29 15:05 | |
Patch attached. |
|||
| msg122813 - (view) | Author: Éric Araujo (merwok) * |
Date: 2010-11-29 15:29 | |
Thank you. I’ll apply after #10578 is solved. |
|||
| msg122814 - (view) | Author: Tarek Ziadé (tarek) * |
Date: 2010-11-29 15:34 | |
Eric: #10578 will not happen in Distutils1. You need to add a test in distutils2, apply the bugfix there, then apply Jakub's patch in distutils1 |
|||
| msg164297 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-06-28 23:07 | |
New changeset ef16a3db4628 by Antoine Pitrou in branch '3.2': Issue #10571: Fix the "--sign" option of distutils' upload command. http://hg.python.org/cpython/rev/ef16a3db4628 New changeset b45f105dbdfb by Antoine Pitrou in branch 'default': Issue #10571: Fix the "--sign" option of distutils' upload command. http://hg.python.org/cpython/rev/b45f105dbdfb |
|||
| msg164298 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2012-06-28 23:08 | |
Committed. Thank you Jakub! |
|||
| msg164574 - (view) | Author: Éric Araujo (merwok) * |
Date: 2012-07-03 05:26 | |
Reopening for d2. According to our rules a unit test would be required, but if we don’t have machinery to test upload already in place then I would just commit it; we definitely want to have automated tests for all commands, but it needn’t hold up this fix. |
|||
| msg214798 - (view) | Author: Éric Araujo (merwok) * |
Date: 2014-03-25 09:24 | |
distutils2 development has ceased. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2014-03-25 09:24:19 | merwok | set | status: open -> closed versions: - 3rd party nosy: + dstufft messages: + msg214798 components: - Distutils2 |
| 2012-07-03 05:26:16 | merwok | set | status: closed -> open stage: resolved -> commit review messages: + msg164574 versions: + 3rd party |
| 2012-06-28 23:08:13 | pitrou | set | status: open -> closed nosy: + pitrou messages: + msg164298 resolution: fixed stage: patch review -> resolved |
| 2012-06-28 23:07:51 | python-dev | set | nosy:
+ python-dev messages: + msg164297 |
| 2012-06-28 23:03:12 | pitrou | set | versions: - Python 2.7 |
| 2012-06-28 23:01:50 | pitrou | set | stage: test needed -> patch review versions: + Python 2.7, - Python 3.4 |
| 2012-06-28 11:09:37 | hynek | set | nosy:
+ hynek versions: + Python 3.4, - Python 3.1 |
| 2011-07-04 14:38:03 | merwok | set | stage: needs patch -> test needed versions: + Python 3.3 |
| 2010-11-29 15:34:22 | tarek | set | nosy:
doko, tarek, jwilk, merwok messages: + msg122814 components: + Distutils2 |
| 2010-11-29 15:29:22 | merwok | set | dependencies:
+ Add mock PyPI server to test distutils messages: + msg122813 |
| 2010-11-29 15:05:01 | jwilk | set | files:
+ issue10571.diff keywords: + patch messages: + msg122807 |
| 2010-11-29 14:10:06 | merwok | set | versions:
+ Python 3.2 messages: + msg122802 assignee: tarek -> merwok type: behavior stage: needs patch |
| 2010-11-29 13:45:48 | merwok | set | messages: - msg122780 |
| 2010-11-29 13:45:45 | merwok | set | messages: - msg122777 |
| 2010-11-29 08:41:45 | jwilk | set | assignee: tarek messages: + msg122780 components: + Distutils, - Library (Lib) nosy: doko, tarek, jwilk, merwok |
| 2010-11-29 07:22:43 | doko | set | nosy:
+ doko messages: + msg122777 assignee: tarek -> (no value) components: + Library (Lib), - Distutils |
| 2010-11-28 23:38:55 | jwilk | create | |