classification
Title: adding bool support to xdrlib.py
Type: Stage:
Components: Library (Lib) Versions: Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: anthonybaxter, irmen, lars.gustaebel, loewis (4)
Priority: normal Keywords: patch

Created on 2004-10-18 11:35 by lars.gustaebel, last changed 2005-02-24 20:23 by loewis.

Files
File name Uploaded Description Edit Remove
xdrlib.patch lars.gustaebel, 2004-10-18 11:35 bool support for Unpacker
Messages (5)
msg47086 - (view) Author: Lars Gustäbel (lars.gustaebel) Date: 2004-10-18 11:35 
xdrlib's Unpacker method unpack_bool() is just an alias
to the unpack_int() method, therefore it returns an
integer. The attached patch adds bool object support to
unpack_bool().
msg47087 - (view) Author: Martin v. Löwis (loewis) Date: 2004-10-19 20:23 
Logged In: YES 
user_id=21627

The patch itself is fine. However, it comes too late for 2.4
- unless Anthony accepts it for 2.4, anyway.
msg47088 - (view) Author: Anthony Baxter (anthonybaxter) Date: 2004-10-20 06:04 
Logged In: YES 
user_id=29957

Nope. This can go in after 2.4 final is out.
msg47089 - (view) Author: Irmen de Jong (irmen) Date: 2005-01-16 16:00 
Logged In: YES 
user_id=129426

It would be nice indeed to have unpack_bool return the type
that was put into there by pack_bool :) And now that 2.4 is
out...
msg47090 - (view) Author: Martin v. Löwis (loewis) Date: 2005-02-24 20:23 
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as

xdrlib.py 1.17
test_sundry.py 1.17
test_xdrlib.py 1.1
output/test_xdrlib 1.1
NEWS 1.1245
History
Date User Action Args
2004-10-18 11:35:52lars.gustaebelcreate