This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Refleak run of test_gettext fails
Type: resource usage Stage: resolved
Components: Tests Versions: Python 3.1, Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.araujo Nosy List: eric.araujo, loewis, pitrou, v_peter
Priority: normal Keywords: needs review, patch

Created on 2010-10-29 10:31 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix-10229.diff eric.araujo, 2010-10-29 16:01
Messages (5)
msg119882 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-10-29 10:31
This is probably caused by r85223.

$ ./python -m test.regrtest -R 3:2 test_gettext
[1/1] test_gettext
beginning 5 repetitions
12345
test test_gettext failed -- Traceback (most recent call last):
  File "/home/antoine/py3k/deallocwarn/Lib/test/test_gettext.py", line 348, in test_cache
    self.assertEqual(len(gettext._translations), 0)
AssertionError: 2 != 0

1 test failed:
    test_gettext
msg119912 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-10-29 16:01
Thanks for catching this.  Attached patch fixes the error with -R and works without -R too, please review.
msg119915 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-10-29 16:10
> Thanks for catching this.  Attached patch fixes the error with -R and
> works without -R too, please review.

It looks good to me.
msg120580 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-11-06 04:13
Fixed in r86239.
msg120581 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-11-06 04:38
Added NEWS entry in r86241.  Fix (including NEWS entry) backported to 3.1 in r862442 and 2.7 in r86243.
History
Date User Action Args
2022-04-11 14:57:08adminsetgithub: 54438
2010-11-06 04:38:10eric.araujosetstatus: open -> closed
resolution: fixed
messages: + msg120581

stage: patch review -> resolved
2010-11-06 04:13:38eric.araujosetmessages: + msg120580
2010-10-29 16:10:33pitrousetmessages: + msg119915
2010-10-29 16:01:15eric.araujosetfiles: + fix-10229.diff

nosy: + loewis, v_peter
messages: + msg119912

keywords: + needs review, patch
stage: needs patch -> patch review
2010-10-29 10:31:33pitroucreate