This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: wave module writes corrupt wav file for zero-length writeframes
Type: behavior Stage:
Components: Library (Lib) Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: eric.araujo, georg.brandl, mu_mind
Priority: normal Keywords: patch

Created on 2010-10-26 15:35 by mu_mind, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix_double_header.patch mu_mind, 2010-10-26 15:38 Patch against python 2.6 wave.py
Messages (8)
msg119609 - (view) Author: David Barnett (mu_mind) Date: 2010-10-26 15:35
If the first call to writeframes happens to take an empty string as the data to write, then the next call to writeframes writes a 2nd header into the file, and forever after fails to patch the data length correctly.
msg119610 - (view) Author: David Barnett (mu_mind) Date: 2010-10-26 15:38
This patch against the python 2.6 version fixes the problem for me.
msg119860 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-10-29 06:28
Thanks, fixed in r85914.
msg120253 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-11-02 19:59
That revision is actually an edit to re.rst.

Is the patch irrelevant for other branches?
msg120384 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-11-04 08:40
I'm sorry, the actual revision is r85970.  Why should it be irrelevant for other branches?
msg120421 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-11-04 16:55
I asked that because I didn’t see the fix backported :)
msg120425 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-11-04 17:35
I always to the backports batched for these minor and docs fixes.
msg120426 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-11-04 17:57
Perfect, sorry for doubting you ;)
History
Date User Action Args
2022-04-11 14:57:07adminsetgithub: 54407
2010-11-04 17:57:11eric.araujosetmessages: + msg120426
2010-11-04 17:35:31georg.brandlsetmessages: + msg120425
2010-11-04 16:55:04eric.araujosetmessages: + msg120421
2010-11-04 08:40:50georg.brandlsetmessages: + msg120384
2010-11-02 19:59:14eric.araujosetnosy: + eric.araujo
messages: + msg120253
2010-10-29 06:28:25georg.brandlsetstatus: open -> closed

nosy: + georg.brandl
messages: + msg119860

resolution: fixed
2010-10-26 15:38:31mu_mindsetfiles: + fix_double_header.patch
keywords: + patch
messages: + msg119610
2010-10-26 15:35:35mu_mindcreate