➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: rlcompleter's tests depend on dict order
Type: Stage: resolved
Components: Tests Versions: Python 3.1, Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Trundle, georg.brandl, ned.deily, pitrou
Priority: normal Keywords: patch

Created on 2010-10-20 22:40 by Trundle, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_rlcompleter_order.patch Trundle, 2010-10-20 22:40
Messages (3)
msg119240 - (view) Author: Andreas Stührk (Trundle) * Date: 2010-10-20 22:40 
Some tests in test_rlcompleter make assumptions about the order of the list of names that the completion methods of a Completer object return. That order is not guaranteed and will break when running the tests under e.g. PyPy.

The attached patch against py3k branch tries to fix that.
msg119243 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2010-10-20 23:34 
The patch looks good to me.
msg119266 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-10-21 07:40 
Applied in r85766. Thanks!
History
Date User Action Args
2022-04-11 14:57:07adminsetgithub: 54368
2010-10-21 07:40:16georg.brandlsetstatus: open -> closed

nosy: + georg.brandl
messages: + msg119266

resolution: fixed
stage: patch review -> resolved
2010-10-20 23:34:52ned.deilysetnosy: + ned.deily, pitrou

messages: + msg119243
stage: patch review
2010-10-20 22:40:13Trundlecreate