diff --git a/Lib/idlelib/textview.py b/Lib/idlelib/textview.py index ab653a9..ba8082c 100644 --- a/Lib/idlelib/textview.py +++ b/Lib/idlelib/textview.py @@ -1,14 +1,51 @@ """Simple text browser for IDLE """ -from tkinter import Toplevel, Frame, Button, Text -from tkinter import DISABLED, SUNKEN, VERTICAL, WORD -from tkinter import RIGHT, LEFT, TOP, BOTTOM, BOTH, X, Y -from tkinter.ttk import Scrollbar +from tkinter import Toplevel, Text +from tkinter.ttk import Frame, Scrollbar, Button from tkinter.messagebox import showerror -class TextViewer(Toplevel): +class ButtonFrame(Frame): + "Display frame for buttons." + + def __init__(self, parent): + """Create a frame for window buttons. + + parent - parent widget for this frame + """ + super().__init__(parent) + self.button_ok = button_ok = Button(self, text='Close', + command=parent.ok, takefocus=False) + button_ok.pack() + + +class TextviewFrame(Frame): + "Display frame for text and scroll." + + def __init__(self, parent, content): + """Create a frame for Textview. + + parent - parent widget for this frame + content - text to display + """ + super().__init__(parent) + self['relief'] = 'sunken' + self['height'] = 700 + self.text = text = Text(self, wrap='word', highlightthickness=0, + fg=parent.fg, bg=parent.bg) + self.scroll = scroll = Scrollbar(self, orient='vertical', + takefocus=False, command=text.yview) + text['yscrollcommand'] = scroll.set + text.insert(0.0, content) + text['state'] = 'disabled' + text.focus_set() + + scroll.pack(side='right', fill='y') + text.pack(side='left', expand=True, fill='both') + + +class TextviewWindow(Toplevel): "A simple text viewer dialog for IDLE." def __init__(self, parent, title, text, modal=True, @@ -24,26 +61,23 @@ class TextViewer(Toplevel): _htest - bool; change box location when running htest. _utest - bool; don't wait_window when running unittest. """ - Toplevel.__init__(self, parent) - self.configure(borderwidth=5) + super().__init__(parent) + self['borderwidth'] = 5 # Place dialog below parent if running htest. - self.geometry("=%dx%d+%d+%d" % (750, 500, - parent.winfo_rootx() + 10, - parent.winfo_rooty() + (10 if not _htest else 100))) + self.geometry("={width}x{height}+{x}+{y}". + format(width=750, height=500, + x=parent.winfo_rootx() + 10, + y=parent.winfo_rooty() + (10 if not _htest else 100))) # TODO: get fg/bg from theme. self.bg = '#ffffff' self.fg = '#000000' - self.create_widgets() self.title(title) self.protocol("WM_DELETE_WINDOW", self.ok) - self.parent = parent - self.text.focus_set() - # Bind keys for closing this dialog. self.bind('', self.ok) self.bind('', self.ok) - self.text.insert(0.0, text) - self.text.config(state=DISABLED) + TextviewFrame(self, text).pack(side='top', expand=True, fill='both') + ButtonFrame(self).pack(side='bottom', fill='x') if modal: self.transient(parent) @@ -51,24 +85,6 @@ class TextViewer(Toplevel): if not _utest: self.wait_window() - def create_widgets(self): - "Create Frame with Text (with vertical Scrollbar) and Button." - frame = Frame(self, relief=SUNKEN, height=700) - frame_buttons = Frame(self) - self.button_ok = Button(frame_buttons, text='Close', - command=self.ok, takefocus=False) - self.scrollbar = Scrollbar(frame, orient=VERTICAL, takefocus=False) - self.text = Text(frame, wrap=WORD, highlightthickness=0, - fg=self.fg, bg=self.bg) - self.scrollbar.config(command=self.text.yview) - self.text.config(yscrollcommand=self.scrollbar.set) - - self.button_ok.pack() - self.scrollbar.pack(side=RIGHT, fill=Y) - self.text.pack(side=LEFT, expand=True, fill=BOTH) - frame_buttons.pack(side=BOTTOM, fill=X) - frame.pack(side=TOP, expand=True, fill=BOTH) - def ok(self, event=None): """Dismiss text viewer dialog.""" self.destroy() @@ -84,7 +100,7 @@ def view_text(parent, title, text, modal=True, _utest=False): dialog is displayed _utest - bool; controls wait_window on unittest """ - return TextViewer(parent, title, text, modal, _utest=_utest) + return TextviewWindow(parent, title, text, modal, _utest=_utest) def view_file(parent, title, filename, encoding=None, modal=True, _utest=False): @@ -113,4 +129,4 @@ if __name__ == '__main__': import unittest unittest.main('idlelib.idle_test.test_textview', verbosity=2, exit=False) from idlelib.idle_test.htest import run - run(TextViewer) + run(TextviewWindow)