# HG changeset patch # Parent 9cafb7baf993bc48dbbd4bb37426ef19ae92f3aa Issue #19884: Avoid spurious output on OS X with Gnu Readline Also adjust the test condition, because enable-meta-key was only added in 6.1, not 6.0. diff -r 9cafb7baf993 Lib/test/test_readline.py --- a/Lib/test/test_readline.py Sat Jun 18 08:32:19 2016 +0000 +++ b/Lib/test/test_readline.py Sat Jun 18 09:26:26 2016 +0000 @@ -111,7 +111,7 @@ class TestReadline(unittest.TestCase): - @unittest.skipIf(readline._READLINE_VERSION < 0x0600 and not is_editline, + @unittest.skipIf(readline._READLINE_VERSION < 0x0601 and not is_editline, "not supported in this library version") def test_init(self): # Issue #19884: Ensure that the ANSI sequence "\033[1034h" is not diff -r 9cafb7baf993 Misc/NEWS --- a/Misc/NEWS Sat Jun 18 08:32:19 2016 +0000 +++ b/Misc/NEWS Sat Jun 18 09:26:26 2016 +0000 @@ -10,6 +10,8 @@ Library ------- +- Issue #19884: Avoid spurious output on OS X with Gnu Readline. + - Issue #26536: socket.ioctl now supports SIO_LOOPBACK_FAST_PATH. Patch by Daniel Stokes. diff -r 9cafb7baf993 Modules/readline.c --- a/Modules/readline.c Sat Jun 18 08:32:19 2016 +0000 +++ b/Modules/readline.c Sat Jun 18 09:26:26 2016 +0000 @@ -1146,19 +1146,22 @@ mod_state->begidx = PyLong_FromLong(0L); mod_state->endidx = PyLong_FromLong(0L); -#ifndef __APPLE__ - if (!isatty(STDOUT_FILENO)) { - /* Issue #19884: stdout is not a terminal. Disable meta modifier - keys to not write the ANSI sequence "\033[1034h" into stdout. On - terminals supporting 8 bit characters like TERM=xterm-256color - (which is now the default Fedora since Fedora 18), the meta key is - used to enable support of 8 bit characters (ANSI sequence - "\033[1034h"). +#ifdef __APPLE__ + if (!using_libedit_emulation) +#endif + { + if (!isatty(STDOUT_FILENO)) { + /* Issue #19884: stdout is not a terminal. Disable meta modifier + keys to not write the ANSI sequence "\033[1034h" into stdout. On + terminals supporting 8 bit characters like TERM=xterm-256color + (which is now the default Fedora since Fedora 18), the meta key is + used to enable support of 8 bit characters (ANSI sequence + "\033[1034h"). - With libedit, this call makes readline() crash. */ - rl_variable_bind ("enable-meta-key", "off"); + With libedit, this call makes readline() crash. */ + rl_variable_bind ("enable-meta-key", "off"); + } } -#endif /* Initialize (allows .inputrc to override) *