diff -r 21cfbcacf0d8 Lib/test/test_tools.py --- a/Lib/test/test_tools.py Thu Jul 03 11:03:46 2014 -0500 +++ b/Lib/test/test_tools.py Thu Jul 03 16:23:42 2014 -0500 @@ -12,21 +12,17 @@ from unittest import mock import shutil import subprocess -import sysconfig import tempfile import textwrap from test import support -from test.script_helper import assert_python_ok, temp_dir +from test.script_helper import assert_python_failure, assert_python_ok -if not sysconfig.is_python_build(): - # XXX some installers do contain the tools, should we detect that - # and run the tests in that case too? - raise unittest.SkipTest('test irrelevant for an installed Python') - -basepath = os.path.join(os.path.dirname(os.path.dirname(os.path.dirname(__file__))), - 'Tools') +basepath = os.path.join( + os.path.dirname(os.path.dirname(os.path.dirname(__file__))), + 'Tools') scriptsdir = os.path.join(basepath, 'scripts') - +if not os.path.isdir(scriptsdir): + raise unittest.SkipTest('Tools/scripts directory not found') class ReindentTests(unittest.TestCase): script = os.path.join(scriptsdir, 'reindent.py') @@ -61,7 +57,7 @@ def test_selftest(self): self.maxDiff = None - with temp_dir() as directory: + with support.temp_dir() as directory: data_path = os.path.join(directory, '_test.py') with open(self.script) as f: closed = f.read() @@ -367,7 +363,7 @@ # added for a script it should be added to the whitelist below. # scripts that have independent tests. - whitelist = ['reindent.py', 'pdeps.py', 'gprof2html'] + whitelist = ['reindent.py', 'pdeps.py', 'gprof2html', 'md5sum.py'] # scripts that can't be imported without running blacklist = ['make_ctype.py'] # scripts that use windows-only modules @@ -449,17 +445,73 @@ self.gprof.main() self.assertTrue(wmock.open.called) +class MD5SumTests(unittest.TestCase): + @classmethod + def setUpClass(cls): + cls.script = os.path.join(scriptsdir, 'md5sum.py') + os.mkdir(support.TESTFN) + cls.fodder = os.path.join(support.TESTFN, 'md5sum.fodder') + with open(cls.fodder, 'wb') as f: + f.write(b'md5sum\r\ntest file\r\n') + cls.fodder_md5 = b'd38dae2eb1ab346a292ef6850f9e1a0d' + cls.fodder_textmode_md5 = b'a8b07894e2ca3f2a4c3094065fa6e0a5' + + @classmethod + def tearDownClass(cls): + support.rmtree(support.TESTFN) + + def test_noargs(self): + rc, out, err = assert_python_ok(self.script) + self.assertTrue( + out.startswith(b'd41d8cd98f00b204e9800998ecf8427e ')) + self.assertFalse(err) + + def test_checksum_fodder(self): + rc, out, err = assert_python_ok(self.script, self.fodder) + self.assertTrue(out.startswith(self.fodder_md5)) + for part in self.fodder.split(os.path.sep): + self.assertIn(part.encode(), out) + self.assertFalse(err) + + def test_dash_l(self): + rc, out, err = assert_python_ok(self.script, '-l', self.fodder) + self.assertIn(self.fodder_md5, out) + parts = self.fodder.split(os.path.sep) + self.assertIn(parts[-1].encode(), out) + self.assertNotIn(parts[-2].encode(), out) + + def test_dash_t(self): + rc, out, err = assert_python_ok(self.script, '-t', self.fodder) + self.assertTrue(out.startswith(self.fodder_textmode_md5)) + self.assertNotIn(self.fodder_md5, out) + + def test_dash_s(self): + rc, out, err = assert_python_ok(self.script, '-s', '512', self.fodder) + self.assertIn(self.fodder_md5, out) + + def test_multiple_files(self): + rc, out, err = assert_python_ok(self.script, self.fodder, self.fodder) + lines = out.splitlines() + self.assertEqual(len(lines), 2) + self.assertEqual(*lines) + + def test_usage(self): + rc, out, err = assert_python_failure(self.script, '-h') + self.assertEqual(rc, 2) + self.assertEqual(out, b'') + self.assertGreater(err, b'') + # Run the tests in Tools/parser/test_unparse.py with support.DirsOnSysPath(os.path.join(basepath, 'parser')): - from test_unparse import UnparseTestCase - from test_unparse import DirectoryTestCase - - -def test_main(): - support.run_unittest(*[obj for obj in globals().values() - if isinstance(obj, type)]) - + try: + from test_unparse import UnparseTestCase + from test_unparse import DirectoryTestCase + except ImportError: + @unittest.skip('test_unparse could not be imported') + class UnparseTestCase(unittest.TestCase): + def test_dummy(self): pass + class DirectoryTestcase(UnparseTestCase): pass if __name__ == '__main__': unittest.main() diff -r 21cfbcacf0d8 Tools/scripts/md5sum.py --- a/Tools/scripts/md5sum.py Thu Jul 03 11:03:46 2014 -0500 +++ b/Tools/scripts/md5sum.py Thu Jul 03 16:23:42 2014 -0500 @@ -9,7 +9,7 @@ rmode = 'rb' usage = """ -usage: sum5 [-b] [-t] [-l] [-s bufsize] [file ...] +usage: md5sum.py [-b] [-t] [-l] [-s bufsize] [file ...] -b : read files in binary mode (default) -t : read files in text mode (you almost certainly don't want this!) -l : print last pathname component only @@ -24,7 +24,7 @@ def sum(*files): sts = 0 - if files and isinstance(files[-1], file): + if files and hasattr(files[-1], 'write'): out, files = files[-1], files[:-1] else: out = sys.stdout @@ -53,12 +53,14 @@ return sts def printsumfp(fp, filename, out=sys.stdout): - m = md5.new() + m = md5() try: while 1: data = fp.read(bufsize) if not data: break + if isinstance(data, str): + data = data.encode(fp.encoding) m.update(data) except IOError as msg: sys.stderr.write('%s: I/O error: %s\n' % (filename, msg))