diff -r 545feebd58fb Lib/selectors.py --- a/Lib/selectors.py Tue Nov 05 22:02:17 2013 +0200 +++ b/Lib/selectors.py Wed Nov 06 01:21:05 2013 +0100 @@ -138,11 +138,14 @@ key = self._fd_to_key[_fileobj_to_fd(fileobj)] except KeyError: raise KeyError("{!r} is not registered".format(fileobj)) from None - if events != key.events or data != key.data: - # TODO: If only the data changed, use a shortcut that only - # updates the data. + if events != key.events: self.unregister(fileobj) return self.register(fileobj, events, data) + elif data != key.data: + # Use a shortcut to update the data. + key = key._replace(data=data) + self._fd_to_key[key.fd] = key + return key else: return key diff -r 545feebd58fb Lib/test/test_selectors.py --- a/Lib/test/test_selectors.py Tue Nov 05 22:02:17 2013 +0200 +++ b/Lib/test/test_selectors.py Wed Nov 06 01:21:05 2013 +0100 @@ -6,6 +6,7 @@ from test import support from time import sleep import unittest +import unittest.mock try: from time import monotonic as time except ImportError: @@ -124,6 +125,15 @@ # modify unknown file obj self.assertRaises(KeyError, s.modify, 999999, selectors.EVENT_READ) + # modify use a shortcut + d3 = object() + s.register = unittest.mock.Mock() + s.unregister = unittest.mock.Mock() + + s.modify(rd, selectors.EVENT_READ, d3) + self.assertFalse(s.register.called) + self.assertFalse(s.unregister.called) + def test_close(self): s = self.SELECTOR() self.addCleanup(s.close)