diff -r 494f736f5945 Lib/test/test_threading.py --- a/Lib/test/test_threading.py Mon Nov 04 11:28:26 2013 +0100 +++ b/Lib/test/test_threading.py Mon Nov 04 21:54:11 2013 +0100 @@ -84,6 +84,7 @@ class BaseTestCase(unittest.TestCase): class ThreadTests(BaseTestCase): + maxDiff = 10000 # Create a bunch of threads, let each do some work, wait until all are # done. @@ -617,6 +618,54 @@ class ThreadTests(BaseTestCase): t.join() self.assertRaises(ValueError, bs.release) + def test_locals_at_exit(self): + # Issue #19466: thread locals must not be deleted before destructors + # are called + rc, out, err = assert_python_ok("-c", """if 1: + import threading + + class Atexit: + def __del__(self): + print("thread_dict.atexit = %r" % thread_dict.atexit) + + thread_dict = threading.local() + thread_dict.atexit = "atexit" + + atexit = Atexit() + """) + self.assertEqual(out.rstrip(), b"thread_dict.atexit = 'atexit'") + + def test_warnings_at_exit(self): + # Issue #19466: try to call most destructors at Python shutdown before + # destroying Python thread states + filename = __file__ + rc, out, err = assert_python_ok("-c", """if 1: + import time + import threading + + def open_sleep(): + # a warning will be emitted when the open file will be + # destroyed (without being explicitly closed) while the daemon + # thread is destroyed + fileobj = open(%a, 'rb') + start.release() + time.sleep(60.0) + + start = threading.Lock() + start.acquire() + + thread = threading.Thread(target=open_sleep) + thread.daemon = True + thread.start() + + # wait until the thread started + start.acquire() + start.release() + """ % filename) + self.assertRegex(err.rstrip(), + b"^sys:1: ResourceWarning: unclosed file ") + + class ThreadJoinOnShutdown(BaseTestCase): def _run_and_join(self, script): @@ -701,6 +750,10 @@ class ThreadJoinOnShutdown(BaseTestCase) import sys import time import threading + import warnings + + # ignore "unclosed file ..." warnings + warnings.filterwarnings('ignore', '', ResourceWarning) thread_has_run = set() diff -r 494f736f5945 Python/pythonrun.c --- a/Python/pythonrun.c Mon Nov 04 11:28:26 2013 +0100 +++ b/Python/pythonrun.c Mon Nov 04 21:54:11 2013 +0100 @@ -566,11 +566,8 @@ Py_Finalize(void) _Py_Finalizing = tstate; initialized = 0; - /* Flush stdout+stderr */ - flush_std_files(); - - /* Disable signal handling */ - PyOS_FiniInterrupts(); + /* Destroy the state of all threads except the current thread */ + _PyThreadState_DeleteExcept(tstate); /* Collect garbage. This may call finalizers; it's nice to call these * before all modules are destroyed. @@ -585,6 +582,7 @@ Py_Finalize(void) * XXX I haven't seen a real-life report of either of these. */ PyGC_Collect(); + #ifdef COUNT_ALLOCS /* With COUNT_ALLOCS, it helps to run GC multiple times: each collection might release some types from the type @@ -592,6 +590,13 @@ Py_Finalize(void) while (PyGC_Collect() > 0) /* nothing */; #endif + + /* Flush stdout+stderr */ + flush_std_files(); + + /* Disable signal handling */ + PyOS_FiniInterrupts(); + /* Destroy all modules */ PyImport_Cleanup();