diff -r db5a50959dc9 Modules/_ssl.c --- a/Modules/_ssl.c Sat Oct 26 03:16:06 2013 -0700 +++ b/Modules/_ssl.c Sun Oct 27 01:03:45 2013 +0200 @@ -1629,7 +1629,7 @@ /* Seed OpenSSL's PRNG at fork(), http://bugs.python.org/issue18747 * - * The parent handler seeds the PRNG from pseudo-random data like pid, the + * The prepare handler seeds the PRNG from pseudo-random data like pid, the * current time (miliseconds or seconds) and an uninitialized array. * The array contains stack variables that are impossible to predict * on most systems, e.g. function return address (subject to ASLR), the @@ -1638,16 +1638,17 @@ * * Note: * The code uses pthread_atfork() until Python has a proper atfork API. The - * handlers are not removed from the child process. A parent handler is used + * handlers are not removed from the child process. A prepare handler is used * instead of a child handler because fork() is supposed to be async-signal - * safe but the handler calls unsafe functions. + * safe but the handler calls unsafe functions. A parent handler has caused + * other problems, see issue #19227. */ #if defined(HAVE_PTHREAD_ATFORK) && defined(WITH_THREAD) #define PYSSL_RAND_ATFORK 1 static void -PySSL_RAND_atfork_parent(void) +PySSL_RAND_atfork_prepare(void) { struct { char stack[128]; /* uninitialized (!) stack data, 128 is an @@ -1673,9 +1674,9 @@ if (registered) return 0; - retval = pthread_atfork(NULL, /* prepare */ - PySSL_RAND_atfork_parent, /* parent */ - NULL); /* child */ + retval = pthread_atfork(PySSL_RAND_atfork_prepare, /* prepare */ + NULL, /* parent */ + NULL); /* child */ if (retval != 0) { PyErr_SetFromErrno(PyExc_OSError); return -1;